Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 2235403002: visualViewport should be [SameObject, Replaceable] (Closed)

Created:
4 years, 4 months ago by ymalik
Modified:
4 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

visualViewport should be [SameObject, Replaceable] BUG=595826 Committed: https://crrev.com/c646cb7d4a37fa4630078912263d07e39ccb2430 Cr-Commit-Position: refs/heads/master@{#411540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
ymalik
4 years, 4 months ago (2016-08-11 20:40:08 UTC) #3
bokan
lgtm
4 years, 4 months ago (2016-08-11 21:13:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235403002/1
4 years, 4 months ago (2016-08-12 02:07:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 03:25:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 03:30:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c646cb7d4a37fa4630078912263d07e39ccb2430
Cr-Commit-Position: refs/heads/master@{#411540}

Powered by Google App Engine
This is Rietveld 408576698