Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 22354006: Omnibox: Convert Shortcuts Scoring Field Trial to Omnibox Bundled Field Trial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index ee072857dad2292a79c1a6b81241cc550df38af0..cde62593f1cbe30ba2ab574d64e156b301e33ddf 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -94,20 +94,22 @@ class OmniboxFieldTrial {
static bool InZeroSuggestFieldTrial();
// ---------------------------------------------------------
- // For the ShortcutsScoring field trial.
-
- // If the field trial is active and the user is in an experiment
- // group, extract from the experiment group name the maximum
- // relevance score ShortcutsProvider:: CalculateScore() can return.
- // Returns true on a successful extraction. If the extraction failed,
- // if the field trial is not active, etc., returns false.
- // CalculateScore()'s return value is a product of this maximum
- // relevance score and some attenuating factors that are all between
- // 0 and 1. (Note that Shortcuts results may have their scores
- // reduced later if the assigned score is higher than allowed for
- // non-inlineable results. Shortcuts results are not allowed to be
+ // For the ShortcutsScoringMaxRelevance experiment that's part of the
+ // bundled omnibox field trial.
+
+ // If the user is in an experiment group that, given the provided
+ // |current_page_classification| context, changes the maximum relevance
+ // ShortcutsProvider::CalculateScore() is supposed to assign, extract
+ // that maximum relevance score and put in in |max_relevance|. Returns
+ // true on a successful extraction. CalculateScore()'s return value is
+ // a product of this maximum relevance score and some attenuating factors
+ // that are all between 0 and 1. (Note that Shortcuts results may have
+ // their scores reduced later if the assigned score is higher than allowed
+ // for non-inlineable results. Shortcuts results are not allowed to be
// inlined.)
- static bool ShortcutsScoringMaxRelevance(int* max_relevance);
+ static bool ShortcutsScoringMaxRelevance(
+ AutocompleteInput::PageClassification current_page_classification,
+ int* max_relevance);
// ---------------------------------------------------------
// For the SearchHistory experiment that's part of the bundled omnibox
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider_unittest.cc ('k') | chrome/browser/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698