Omnibox: Convert Shortcuts Scoring Field Trial to Omnibox Bundled Field Trial

chrome/browser/omnibox/omnibox_field_trial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 76 matching lines @@
 
   // ---------------------------------------------------------
   // For the ZeroSuggestProvider field trial.
 
   // Returns whether the user is in any field trial where the
   // ZeroSuggestProvider should be used to get suggestions when the
   // user clicks on the omnibox but has not typed anything yet.
   static bool InZeroSuggestFieldTrial();
 
   // ---------------------------------------------------------
-  // For the ShortcutsScoring field trial.
+  // For the ShortcutsScoringMaxRelevance experiment that's part of the
+  // bundled omnibox field trial.
 
-  // If the field trial is active and the user is in an experiment
-  // group, extract from the experiment group name the maximum
-  // relevance score ShortcutsProvider:: CalculateScore() can return.
-  // Returns true on a successful extraction.  If the extraction failed,
-  // if the field trial is not active, etc., returns false.
-  // CalculateScore()'s return value is a product of this maximum
-  // relevance score and some attenuating factors that are all between
-  // 0 and 1.  (Note that Shortcuts results may have their scores
-  // reduced later if the assigned score is higher than allowed for
-  // non-inlineable results.  Shortcuts results are not allowed to be
+  // If the user is in an experiment group that, given the provided
+  // |current_page_classification| context, changes the maximum relevance
+  // ShortcutsProvider::CalculateScore() is supposed to assign, extract
+  // that maximum relevance score and put in in |max_relevance|.  Returns
+  // true on a successful extraction.  CalculateScore()'s return value is
+  // a product of this maximum relevance score and some attenuating factors
+  // that are all between 0 and 1.  (Note that Shortcuts results may have
+  // their scores reduced later if the assigned score is higher than allowed
+  // for non-inlineable results.  Shortcuts results are not allowed to be
   // inlined.)
-  static bool ShortcutsScoringMaxRelevance(int* max_relevance);
+  static bool ShortcutsScoringMaxRelevance(
+      AutocompleteInput::PageClassification current_page_classification,
+      int* max_relevance);
 
   // ---------------------------------------------------------
   // For the SearchHistory experiment that's part of the bundled omnibox
   // field trial.
 
   // Returns true if the user is in the experiment group that, given the
   // provided |current_page_classification| context, scores search history
   // query suggestions less aggressively so that they don't inline.
   static bool SearchHistoryPreventInlining(
       AutocompleteInput::PageClassification current_page_classification);
@@ skipping 36 matching lines @@
   // details, see the implementation.  How to interpret the value is left
   // to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       AutocompleteInput::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_