Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 22354005: Add support for maintaining ordinal values through GestureRecognizer (Closed)

Created:
7 years, 4 months ago by DaveMoore
Modified:
7 years, 4 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add support for maintaining ordinal values through GestureRecognizer BUG=271005 TEST=Added checks in existing tests R=rjkroege@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217102

Patch Set 1 #

Patch Set 2 : A few more test checks #

Patch Set 3 : Fix to fling #

Total comments: 4

Patch Set 4 : Fix to fling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -6 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 8 chunks +36 lines, -1 line 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 2 3 chunks +10 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_types.h View 5 chunks +38 lines, -1 line 0 comments Download
M ui/base/gestures/gesture_types.cc View 1 2 3 2 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
DaveMoore
A few more test checks
7 years, 4 months ago (2013-08-09 21:39:33 UTC) #1
DaveMoore
7 years, 4 months ago (2013-08-09 21:40:11 UTC) #2
DaveMoore
Fix to fling
7 years, 4 months ago (2013-08-09 22:15:09 UTC) #3
rjkroege
https://codereview.chromium.org/22354005/diff/7001/ui/base/gestures/gesture_types.cc File ui/base/gestures/gesture_types.cc (right): https://codereview.chromium.org/22354005/diff/7001/ui/base/gestures/gesture_types.cc#newcode25 ui/base/gestures/gesture_types.cc:25: data.scroll_update.x_ordinal = delta_x; should be fling_velocity? https://codereview.chromium.org/22354005/diff/7001/ui/base/gestures/gesture_types.cc#newcode85 ui/base/gestures/gesture_types.cc:85: data.scroll_update.x_ordinal ...
7 years, 4 months ago (2013-08-09 22:18:43 UTC) #4
DaveMoore
Fix to fling
7 years, 4 months ago (2013-08-12 20:37:23 UTC) #5
DaveMoore
Oddly I had caught that but something went wrong w/ my upload. https://codereview.chromium.org/22354005/diff/7001/ui/base/gestures/gesture_types.cc File ui/base/gestures/gesture_types.cc ...
7 years, 4 months ago (2013-08-12 20:38:16 UTC) #6
rjkroege
lgtm
7 years, 4 months ago (2013-08-12 21:20:46 UTC) #7
DaveMoore
7 years, 4 months ago (2013-08-12 22:33:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r217102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698