Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: webrtc/modules/pacing/bitrate_prober_unittest.cc

Issue 2235373004: Probing: Add support for exponential startup probing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@fix_probing2
Patch Set: Updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/bitrate_prober_unittest.cc
diff --git a/webrtc/modules/pacing/bitrate_prober_unittest.cc b/webrtc/modules/pacing/bitrate_prober_unittest.cc
index ce63781e6871b01604e3eef4344a5d9bf9f57582..4b5c65feef67d7d23054fbd07e049b45e01c7c46 100644
--- a/webrtc/modules/pacing/bitrate_prober_unittest.cc
+++ b/webrtc/modules/pacing/bitrate_prober_unittest.cc
@@ -15,6 +15,12 @@
namespace webrtc {
+namespace {
+
+constexpr int probe_multipliers[2] = {3, 6};
stefan-webrtc 2016/08/16 11:27:04 kProbeMultipliers
Irfan 2016/08/16 18:12:47 Done.
+
+} // namespace
+
TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) {
BitrateProber prober;
EXPECT_FALSE(prober.IsProbing());
@@ -24,7 +30,7 @@ TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) {
prober.SetEnabled(true);
EXPECT_FALSE(prober.IsProbing());
- prober.OnIncomingPacket(300000, 1000, now_ms);
+ prober.InitiateProbing(300000, probe_multipliers, 2);
EXPECT_TRUE(prober.IsProbing());
EXPECT_EQ(0, prober.CurrentClusterId());
@@ -62,34 +68,21 @@ TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) {
prober.SetEnabled(true);
EXPECT_FALSE(prober.IsProbing());
- prober.OnIncomingPacket(300000, 1000, now_ms);
+ prober.InitiateProbing(300000, probe_multipliers, 2);
EXPECT_TRUE(prober.IsProbing());
EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
prober.PacketSent(now_ms, 1000);
// Let time pass, no large enough packets put into prober.
now_ms += 6000;
EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
- // Insert a small packet, not a candidate for probing.
- prober.OnIncomingPacket(300000, 100, now_ms);
- prober.PacketSent(now_ms, 100);
- EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
// Insert a large-enough packet after downtime while probing should reset to
// perform a new probe since the requested one didn't finish.
- prober.OnIncomingPacket(300000, 1000, now_ms);
+ prober.InitiateProbing(300000, probe_multipliers, 2);
EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
prober.PacketSent(now_ms, 1000);
// Next packet should be part of new probe and be sent with non-zero delay.
- prober.OnIncomingPacket(300000, 1000, now_ms);
+ prober.InitiateProbing(300000, probe_multipliers, 2);
EXPECT_GT(prober.TimeUntilNextProbe(now_ms), 0);
}
-TEST(BitrateProberTest, DoesntInitializeProbingForSmallPackets) {
- BitrateProber prober;
- prober.SetEnabled(true);
- EXPECT_FALSE(prober.IsProbing());
-
- prober.OnIncomingPacket(300000, 100, 0);
- EXPECT_FALSE(prober.IsProbing());
-}
-
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698