webrtc/modules/congestion_controller/delay_based_bwe.h - Issue 2235373004: Probing: Add support for exponential startup probing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2235373004: Probing: Add support for exponential startup probing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@fix_probing2

Patch Set: Address comments and add unit tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/congestion_controller.cc ('K') | « webrtc/modules/congestion_controller/congestion_controller_unittest.cc ('k') | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | webrtc/modules/congestion_controller/probe_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/delay_based_bwe.h

diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.h b/webrtc/modules/congestion_controller/delay_based_bwe.h

index 19410c658a4f72624228b68c09d10b5a02321646..c3c2d9a880b6e394aacd43a9a7b0c4c56c6b4392 100644

--- a/webrtc/modules/congestion_controller/delay_based_bwe.h

+++ b/webrtc/modules/congestion_controller/delay_based_bwe.h

@@ -57,6 +57,11 @@ class DelayBasedBwe : public RemoteBitrateEstimator {

private:

void IncomingPacketInfo(const PacketInfo& info);

+ // Updates the current remote rate estimate and returns true if a valid

+ // estimate exists.

+ bool UpdateEstimate(int64_t packet_arrival_time_ms,

+ int64_t now_ms,

+ uint32_t* target_bitrate_bps);

philipel 2016/09/09 08:59:09 Add EXCLUSIVE_LOCKS_REQUIRED(crit_) annotation and

Irfan 2016/09/12 06:40:40 Done.

rtc::ThreadChecker network_thread_;

Clock* const clock_;

@@ -65,7 +70,6 @@ class DelayBasedBwe : public RemoteBitrateEstimator {

std::unique_ptr<OveruseEstimator> estimator_;

OveruseDetector detector_;

RateStatistics incoming_bitrate_;

- int64_t first_packet_time_ms_;

int64_t last_update_ms_;

int64_t last_seen_packet_ms_;

bool uma_recorded_;