Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2235373002: Roll buildtools 33a32b8aa2..f8fc76ea5c (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 33a32b8aa2..f8fc76ea5c In order to roll GN 5822d6c9a8..4838fe571d (r410471:r411399) and pick up the following changes: ba1286d GN: Mark all variables used when defining a template. fcd8d22 Stop pointing to "gn help toolchain" in that very help message. db9ce41 Fix GN bootstrap 56350de GN: Throw an error overwriting a nonempty scope. TBR=dpranke@chromium.org Committed: https://crrev.com/08912711cf3a444f406777e9d055559b4d208a4e Cr-Commit-Position: refs/heads/master@{#411478}

Patch Set 1 #

Patch Set 2 : Fix Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 1 3 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
brettw
4 years, 4 months ago (2016-08-11 19:54:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235373002/1
4 years, 4 months ago (2016-08-11 19:54:44 UTC) #3
brettw
Fix Windows
4 years, 4 months ago (2016-08-11 20:34:54 UTC) #4
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-11 22:50:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235373002/20001
4 years, 4 months ago (2016-08-11 22:52:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 00:29:54 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 00:32:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08912711cf3a444f406777e9d055559b4d208a4e
Cr-Commit-Position: refs/heads/master@{#411478}

Powered by Google App Engine
This is Rietveld 408576698