Manual Rebase for video-buffered-range-contains-currentTime.html

Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956
Committed: https://crrev.com/768b9151d655f6c0ebce772e8d0705d1e09c8038
Cr-Commit-Position: refs/heads/master@{#412521}

[Srirama, 2016-08-13 16:54:55]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-08-13 16:55:17]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-13 16:55:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 17:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 17:59:05]

Dry run: This issue passed the CQ dry run.

[Srirama, 2016-08-16 04:56:51]

Description was changed from

==========
fix

BUG=
==========

to

==========
Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956
==========

[Srirama, 2016-08-16 05:05:09]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-08-16 05:05:09]

PTAL.
Running ./Tools/Script/webkit-patch rebaseline-expectations test_name as per
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
doesn't work. It gives me an error "Did not find any tests marked Rebaseline".
So i just collected expectations manually from the trybots/waterfallbots ... I
am able to get expectations for all the ports except for android.
Please let me know if this is not the right way.

[fs, 2016-08-16 07:47:18]

On 2016/08/16 at 05:05:09, srirama.m wrote:
> PTAL.
> Running ./Tools/Script/webkit-patch rebaseline-expectations test_name as per
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
doesn't work. It gives me an error "Did not find any tests marked Rebaseline".

Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or maybe
"NeedsRebaseline") and then run that command. (IIRC running "webkit-patch
rebaseline" will also work.)

[Srirama, 2016-08-16 11:59:05]

On 2016/08/16 07:47:18, fs wrote:
> On 2016/08/16 at 05:05:09, srirama.m wrote:
> > PTAL.
> > Running ./Tools/Script/webkit-patch rebaseline-expectations test_name as per
>
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> doesn't work. It gives me an error "Did not find any tests marked Rebaseline".
> 
> Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or maybe
> "NeedsRebaseline") and then run that command. (IIRC running "webkit-patch
> rebaseline" will also work.)

"webkit-patch rebaseline" prompts for builders but doesn't seem to generate any
output.
**************************
$ ./Tools/Scripts/webkit-patch rebaseline
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
Which builder to pull results from:
 1. WebKit Android (Nexus4)
 2. WebKit Linux
 3. WebKit Linux Trusty
 4. WebKit Mac10.10
 5. WebKit Mac10.11
 6. WebKit Mac10.11 (retina)
 7. WebKit Mac10.9
 8. WebKit Win10
 9. WebKit Win7
Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or "all": all
Rebaselining
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
**************************

git status doesn't show anything.
How about auto rebaselining with "NeedsRebaseline" ?

[fs, 2016-08-16 12:50:27]

On 2016/08/16 at 11:59:05, srirama.m wrote:
> On 2016/08/16 07:47:18, fs wrote:
> > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > PTAL.
> > > Running ./Tools/Script/webkit-patch rebaseline-expectations test_name as
per
> >
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > doesn't work. It gives me an error "Did not find any tests marked
Rebaseline".
> > 
> > Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or maybe
> > "NeedsRebaseline") and then run that command. (IIRC running "webkit-patch
> > rebaseline" will also work.)
> 
> "webkit-patch rebaseline" prompts for builders but doesn't seem to generate
any output.
> **************************
> $ ./Tools/Scripts/webkit-patch rebaseline
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> Which builder to pull results from:
>  1. WebKit Android (Nexus4)
>  2. WebKit Linux
>  3. WebKit Linux Trusty
>  4. WebKit Mac10.10
>  5. WebKit Mac10.11
>  6. WebKit Mac10.11 (retina)
>  7. WebKit Mac10.9
>  8. WebKit Win10
>  9. WebKit Win7
> Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or "all":
all
> Rebaselining
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> **************************
> 
> git status doesn't show anything.
> How about auto rebaselining with "NeedsRebaseline" ?

If you did that "on top of" this patch, then "no changes" is probably correct.
Please also include the TestExpectations change in this CL so that the bots can
check the results.

[Srirama, 2016-08-16 12:56:27]

On 2016/08/16 12:50:27, fs wrote:
> On 2016/08/16 at 11:59:05, srirama.m wrote:
> > On 2016/08/16 07:47:18, fs wrote:
> > > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > > PTAL.
> > > > Running ./Tools/Script/webkit-patch rebaseline-expectations test_name as
> per
> > >
>
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > > doesn't work. It gives me an error "Did not find any tests marked
> Rebaseline".
> > > 
> > > Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or
maybe
> > > "NeedsRebaseline") and then run that command. (IIRC running "webkit-patch
> > > rebaseline" will also work.)
> > 
> > "webkit-patch rebaseline" prompts for builders but doesn't seem to generate
> any output.
> > **************************
> > $ ./Tools/Scripts/webkit-patch rebaseline
> LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> > Which builder to pull results from:
> >  1. WebKit Android (Nexus4)
> >  2. WebKit Linux
> >  3. WebKit Linux Trusty
> >  4. WebKit Mac10.10
> >  5. WebKit Mac10.11
> >  6. WebKit Mac10.11 (retina)
> >  7. WebKit Mac10.9
> >  8. WebKit Win10
> >  9. WebKit Win7
> > Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or "all":
> all
> > Rebaselining
> LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> > **************************
> > 
> > git status doesn't show anything.
> > How about auto rebaselining with "NeedsRebaseline" ?
> 
> If you did that "on top of" this patch, then "no changes" is probably correct.
> Please also include the TestExpectations change in this CL so that the bots
can
> check the results.

Infact i have tested with both "NeedsRebaseline" as well as "Rebaseline".
So shall i upload the patch with "NeedsRebaseline" and removing my manual
changes to the expected files?

[fs, 2016-08-16 13:07:07]

On 2016/08/16 at 12:56:27, srirama.m wrote:
> On 2016/08/16 12:50:27, fs wrote:
> > On 2016/08/16 at 11:59:05, srirama.m wrote:
> > > On 2016/08/16 07:47:18, fs wrote:
> > > > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > > > PTAL.
> > > > > Running ./Tools/Script/webkit-patch rebaseline-expectations test_name
as
> > per
> > > >
> >
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > > > doesn't work. It gives me an error "Did not find any tests marked
> > Rebaseline".
> > > > 
> > > > Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or
maybe
> > > > "NeedsRebaseline") and then run that command. (IIRC running
"webkit-patch
> > > > rebaseline" will also work.)
> > > 
> > > "webkit-patch rebaseline" prompts for builders but doesn't seem to
generate
> > any output.
> > > **************************
> > > $ ./Tools/Scripts/webkit-patch rebaseline
> > LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> > > Which builder to pull results from:
> > >  1. WebKit Android (Nexus4)
> > >  2. WebKit Linux
> > >  3. WebKit Linux Trusty
> > >  4. WebKit Mac10.10
> > >  5. WebKit Mac10.11
> > >  6. WebKit Mac10.11 (retina)
> > >  7. WebKit Mac10.9
> > >  8. WebKit Win10
> > >  9. WebKit Win7
> > > Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or
"all":
> > all
> > > Rebaselining
> > LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> > > **************************
> > > 
> > > git status doesn't show anything.
> > > How about auto rebaselining with "NeedsRebaseline" ?
> > 
> > If you did that "on top of" this patch, then "no changes" is probably
correct.
> > Please also include the TestExpectations change in this CL so that the bots
can
> > check the results.
> 
> Infact i have tested with both "NeedsRebaseline" as well as "Rebaseline".
> So shall i upload the patch with "NeedsRebaseline" and removing my manual
changes to the expected files?

I changed "NeedsManualRebaseline" -> "Rebaseline", ran "webkit-patch
rebaseline-expectations" and got a result with a diff like:

 third_party/WebKit/LayoutTests/TestExpectations                                
           |   1 -

.../LayoutTests/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
   |   7 -------

.../android/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
       |   7 +++++++

.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
| Bin 12527 -> 4322 bytes

.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
|  33 +++++++++++++++++++++++++++++++++

.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.png
   | Bin 8292 -> 6034 bytes

.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
   |   5 +++++

.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png
  | Bin 6034 -> 3983 bytes

.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
  |  33 +++++++++++++++++++++++++++++++++

.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png
  | Bin 5974 -> 3934 bytes

.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
  |  33 +++++++++++++++++++++++++++++++++

.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.png
 | Bin 6025 -> 3988 bytes

.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
 |  33 +++++++++++++++++++++++++++++++++
 13 files changed, 144 insertions(+), 8 deletions(-)

which only differs a little from what you've got here - could you try that and
see if the result is similar (the mac-mac10.9 result I guess is the one that is
flaky, so if you can preserve the result you've got here for that bot that is
probably best - the one I downloaded from the bots is clearly wrong...)

Also restore the commented out expectation for the test.

[Srirama, 2016-08-16 14:03:22]

On 2016/08/16 13:07:07, fs wrote:
> On 2016/08/16 at 12:56:27, srirama.m wrote:
> > On 2016/08/16 12:50:27, fs wrote:
> > > On 2016/08/16 at 11:59:05, srirama.m wrote:
> > > > On 2016/08/16 07:47:18, fs wrote:
> > > > > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > > > > PTAL.
> > > > > > Running ./Tools/Script/webkit-patch rebaseline-expectations
test_name
> as
> > > per
> > > > >
> > >
>
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > > > > doesn't work. It gives me an error "Did not find any tests marked
> > > Rebaseline".
> > > > > 
> > > > > Try changing the "NeedsManualRebaseline" you added to "Rebaseline" (or
> maybe
> > > > > "NeedsRebaseline") and then run that command. (IIRC running
> "webkit-patch
> > > > > rebaseline" will also work.)
> > > > 
> > > > "webkit-patch rebaseline" prompts for builders but doesn't seem to
> generate
> > > any output.
> > > > **************************
> > > > $ ./Tools/Scripts/webkit-patch rebaseline
> > >
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> > > > Which builder to pull results from:
> > > >  1. WebKit Android (Nexus4)
> > > >  2. WebKit Linux
> > > >  3. WebKit Linux Trusty
> > > >  4. WebKit Mac10.10
> > > >  5. WebKit Mac10.11
> > > >  6. WebKit Mac10.11 (retina)
> > > >  7. WebKit Mac10.9
> > > >  8. WebKit Win10
> > > >  9. WebKit Win7
> > > > Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or
> "all":
> > > all
> > > > Rebaselining
> > >
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> > > > **************************
> > > > 
> > > > git status doesn't show anything.
> > > > How about auto rebaselining with "NeedsRebaseline" ?
> > > 
> > > If you did that "on top of" this patch, then "no changes" is probably
> correct.
> > > Please also include the TestExpectations change in this CL so that the
bots
> can
> > > check the results.
> > 
> > Infact i have tested with both "NeedsRebaseline" as well as "Rebaseline".
> > So shall i upload the patch with "NeedsRebaseline" and removing my manual
> changes to the expected files?
> 
> I changed "NeedsManualRebaseline" -> "Rebaseline", ran "webkit-patch
> rebaseline-expectations" and got a result with a diff like:
> 
>  third_party/WebKit/LayoutTests/TestExpectations                              
 
>            |   1 -
> 
>
.../LayoutTests/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>    |   7 -------
> 
>
.../android/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>        |   7 +++++++
> 
>
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> | Bin 12527 -> 4322 bytes
> 
>
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> |  33 +++++++++++++++++++++++++++++++++
> 
>
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.png
>    | Bin 8292 -> 6034 bytes
> 
>
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>    |   5 +++++
> 
>
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png
>   | Bin 6034 -> 3983 bytes
> 
>
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>   |  33 +++++++++++++++++++++++++++++++++
> 
>
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png
>   | Bin 5974 -> 3934 bytes
> 
>
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>   |  33 +++++++++++++++++++++++++++++++++
> 
>
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.png
>  | Bin 6025 -> 3988 bytes
> 
>
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
>  |  33 +++++++++++++++++++++++++++++++++
>  13 files changed, 144 insertions(+), 8 deletions(-)
> 
> which only differs a little from what you've got here - could you try that and
> see if the result is similar (the mac-mac10.9 result I guess is the one that
is
> flaky, so if you can preserve the result you've got here for that bot that is
> probably best - the one I downloaded from the bots is clearly wrong...)
> 
Done, rebaselined following your commands, copied mac-10.9 results which i have
already prepared in patchset1.
> Also restore the commented out expectation for the test.
Do we still need that line? or should we let it go on the bots and see how it
fares?

[fs, 2016-08-16 14:09:15]

On 2016/08/16 at 14:03:22, srirama.m wrote:
> On 2016/08/16 13:07:07, fs wrote:
> > On 2016/08/16 at 12:56:27, srirama.m wrote:
> > > On 2016/08/16 12:50:27, fs wrote:
> > > > On 2016/08/16 at 11:59:05, srirama.m wrote:
> > > > > On 2016/08/16 07:47:18, fs wrote:
> > > > > > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > > > > > PTAL.
> > > > > > > Running ./Tools/Script/webkit-patch rebaseline-expectations
test_name
> > as
> > > > per
> > > > > >
> > > >
> >
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > > > > > doesn't work. It gives me an error "Did not find any tests marked
> > > > Rebaseline".
> > > > > > 
> > > > > > Try changing the "NeedsManualRebaseline" you added to "Rebaseline"
(or
> > maybe
> > > > > > "NeedsRebaseline") and then run that command. (IIRC running
> > "webkit-patch
> > > > > > rebaseline" will also work.)
> > > > > 
> > > > > "webkit-patch rebaseline" prompts for builders but doesn't seem to
> > generate
> > > > any output.
> > > > > **************************
> > > > > $ ./Tools/Scripts/webkit-patch rebaseline
> > > >
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> > > > > Which builder to pull results from:
> > > > >  1. WebKit Android (Nexus4)
> > > > >  2. WebKit Linux
> > > > >  3. WebKit Linux Trusty
> > > > >  4. WebKit Mac10.10
> > > > >  5. WebKit Mac10.11
> > > > >  6. WebKit Mac10.11 (retina)
> > > > >  7. WebKit Mac10.9
> > > > >  8. WebKit Win10
> > > > >  9. WebKit Win7
> > > > > Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or
> > "all":
> > > > all
> > > > > Rebaselining
> > > >
LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> > > > > **************************
> > > > > 
> > > > > git status doesn't show anything.
> > > > > How about auto rebaselining with "NeedsRebaseline" ?
> > > > 
> > > > If you did that "on top of" this patch, then "no changes" is probably
> > correct.
> > > > Please also include the TestExpectations change in this CL so that the
bots
> > can
> > > > check the results.
> > > 
> > > Infact i have tested with both "NeedsRebaseline" as well as "Rebaseline".
> > > So shall i upload the patch with "NeedsRebaseline" and removing my manual
> > changes to the expected files?
> > 
> > I changed "NeedsManualRebaseline" -> "Rebaseline", ran "webkit-patch
> > rebaseline-expectations" and got a result with a diff like:
> > 
> >  third_party/WebKit/LayoutTests/TestExpectations                            
   
> >            |   1 -
> > 
> >
.../LayoutTests/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >    |   7 -------
> > 
> >
.../android/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >        |   7 +++++++
> > 
> >
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > | Bin 12527 -> 4322 bytes
> > 
> >
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > |  33 +++++++++++++++++++++++++++++++++
> > 
> >
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> >    | Bin 8292 -> 6034 bytes
> > 
> >
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >    |   5 +++++
> > 
> >
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> >   | Bin 6034 -> 3983 bytes
> > 
> >
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >   |  33 +++++++++++++++++++++++++++++++++
> > 
> >
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> >   | Bin 5974 -> 3934 bytes
> > 
> >
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >   |  33 +++++++++++++++++++++++++++++++++
> > 
> >
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> >  | Bin 6025 -> 3988 bytes
> > 
> >
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> >  |  33 +++++++++++++++++++++++++++++++++
> >  13 files changed, 144 insertions(+), 8 deletions(-)
> > 
> > which only differs a little from what you've got here - could you try that
and
> > see if the result is similar (the mac-mac10.9 result I guess is the one that
is
> > flaky, so if you can preserve the result you've got here for that bot that
is
> > probably best - the one I downloaded from the bots is clearly wrong...)
> > 
> Done, rebaselined following your commands, copied mac-10.9 results which i
have already prepared in patchset1.
> > Also restore the commented out expectation for the test.
> Do we still need that line? or should we let it go on the bots and see how it
fares?

It seems fairly obvious that it's flaky at least on macOS 10.9, but we can land
this CL first and then restore the old test expectation (possibly narrowing it
to 10.9 if that's the only place it flakes.)

LGTM

[Srirama, 2016-08-16 14:11:33]

On 2016/08/16 14:09:15, fs wrote:
> On 2016/08/16 at 14:03:22, srirama.m wrote:
> > On 2016/08/16 13:07:07, fs wrote:
> > > On 2016/08/16 at 12:56:27, srirama.m wrote:
> > > > On 2016/08/16 12:50:27, fs wrote:
> > > > > On 2016/08/16 at 11:59:05, srirama.m wrote:
> > > > > > On 2016/08/16 07:47:18, fs wrote:
> > > > > > > On 2016/08/16 at 05:05:09, srirama.m wrote:
> > > > > > > > PTAL.
> > > > > > > > Running ./Tools/Script/webkit-patch rebaseline-expectations
> test_name
> > > as
> > > > > per
> > > > > > >
> > > > >
> > >
>
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations
> > > > > > > doesn't work. It gives me an error "Did not find any tests marked
> > > > > Rebaseline".
> > > > > > > 
> > > > > > > Try changing the "NeedsManualRebaseline" you added to "Rebaseline"
> (or
> > > maybe
> > > > > > > "NeedsRebaseline") and then run that command. (IIRC running
> > > "webkit-patch
> > > > > > > rebaseline" will also work.)
> > > > > > 
> > > > > > "webkit-patch rebaseline" prompts for builders but doesn't seem to
> > > generate
> > > > > any output.
> > > > > > **************************
> > > > > > $ ./Tools/Scripts/webkit-patch rebaseline
> > > > >
> LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html 
> > > > > > Which builder to pull results from:
> > > > > >  1. WebKit Android (Nexus4)
> > > > > >  2. WebKit Linux
> > > > > >  3. WebKit Linux Trusty
> > > > > >  4. WebKit Mac10.10
> > > > > >  5. WebKit Mac10.11
> > > > > >  6. WebKit Mac10.11 (retina)
> > > > > >  7. WebKit Mac10.9
> > > > > >  8. WebKit Win10
> > > > > >  9. WebKit Win7
> > > > > > Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or
> > > "all":
> > > > > all
> > > > > > Rebaselining
> > > > >
> LayoutTests/http/tests/media/video-buffered-range-contains-currentTime.html
> > > > > > **************************
> > > > > > 
> > > > > > git status doesn't show anything.
> > > > > > How about auto rebaselining with "NeedsRebaseline" ?
> > > > > 
> > > > > If you did that "on top of" this patch, then "no changes" is probably
> > > correct.
> > > > > Please also include the TestExpectations change in this CL so that the
> bots
> > > can
> > > > > check the results.
> > > > 
> > > > Infact i have tested with both "NeedsRebaseline" as well as
"Rebaseline".
> > > > So shall i upload the patch with "NeedsRebaseline" and removing my
manual
> > > changes to the expected files?
> > > 
> > > I changed "NeedsManualRebaseline" -> "Rebaseline", ran "webkit-patch
> > > rebaseline-expectations" and got a result with a diff like:
> > > 
> > >  third_party/WebKit/LayoutTests/TestExpectations                          
 
>    
> > >            |   1 -
> > > 
> > >
>
.../LayoutTests/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >    |   7 -------
> > > 
> > >
>
.../android/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >        |   7 +++++++
> > > 
> > >
>
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > > | Bin 12527 -> 4322 bytes
> > > 
> > >
>
.../platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > > |  33 +++++++++++++++++++++++++++++++++
> > > 
> > >
>
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > >    | Bin 8292 -> 6034 bytes
> > > 
> > >
>
.../mac-mac10.9/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >    |   5 +++++
> > > 
> > >
>
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > >   | Bin 6034 -> 3983 bytes
> > > 
> > >
>
.../platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >   |  33 +++++++++++++++++++++++++++++++++
> > > 
> > >
>
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > >   | Bin 5974 -> 3934 bytes
> > > 
> > >
>
.../platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >   |  33 +++++++++++++++++++++++++++++++++
> > > 
> > >
>
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.png
> > >  | Bin 6025 -> 3988 bytes
> > > 
> > >
>
.../platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
> > >  |  33 +++++++++++++++++++++++++++++++++
> > >  13 files changed, 144 insertions(+), 8 deletions(-)
> > > 
> > > which only differs a little from what you've got here - could you try that
> and
> > > see if the result is similar (the mac-mac10.9 result I guess is the one
that
> is
> > > flaky, so if you can preserve the result you've got here for that bot that
> is
> > > probably best - the one I downloaded from the bots is clearly wrong...)
> > > 
> > Done, rebaselined following your commands, copied mac-10.9 results which i
> have already prepared in patchset1.
> > > Also restore the commented out expectation for the test.
> > Do we still need that line? or should we let it go on the bots and see how
it
> fares?
> 
> It seems fairly obvious that it's flaky at least on macOS 10.9, but we can
land
> this CL first and then restore the old test expectation (possibly narrowing it
> to 10.9 if that's the only place it flakes.)
> 
> LGTM

agreed.

[Srirama, 2016-08-16 14:11:39]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-08-16 14:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:41:31]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Srirama, 2016-08-17 11:12:09]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 11:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 12:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 12:37:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Srirama, 2016-08-17 12:49:20]

Patchset #4 (id:80001) has been deleted

[Srirama, 2016-08-17 12:50:00]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 12:50:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 13:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 13:59:17]

Dry run: This issue passed the CQ dry run.

[Srirama, 2016-08-17 14:09:18]

Test is failing on mac and windows, so updated expectations on win7 and marked
as flaky (Timeout, Failure) on mac.

[fs, 2016-08-17 14:25:42]

On 2016/08/17 at 14:09:18, srirama.m wrote:
> Test is failing on mac and windows, so updated expectations on win7 and marked
as flaky (Timeout, Failure) on mac.

LGTM

[Srirama, 2016-08-17 14:29:10]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-08-17 14:29:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:34:23]

Description was changed from

==========
Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956
==========

to

==========
Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956
==========

[commit-bot: I haz the power, 2016-08-17 14:34:26]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-08-17 14:37:48]

Description was changed from

==========
Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956
==========

to

==========
Manual Rebase for video-buffered-range-contains-currentTime.html

BUG=588956

Committed: https://crrev.com/768b9151d655f6c0ebce772e8d0705d1e09c8038
Cr-Commit-Position: refs/heads/master@{#412521}
==========

[commit-bot: I haz the power, 2016-08-17 14:37:49]

Patchset 4 (id:??) landed as
https://crrev.com/768b9151d655f6c0ebce772e8d0705d1e09c8038
Cr-Commit-Position: refs/heads/master@{#412521}