Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2235323003: [debugger] add test for debug evaluate. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add test for debug evaluate. This test would have failed prior to 58524d6df3. R=verwaest@chromium.org Committed: https://crrev.com/1b43aab528ed213e8d0e0a372b36832fc8ad5d06 Cr-Commit-Position: refs/heads/master@{#38610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A test/mjsunit/debug-evaluate-shadowed-context-2.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 4 months ago (2016-08-12 10:32:32 UTC) #1
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-12 10:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235323003/1
4 years, 4 months ago (2016-08-12 10:55:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 11:18:55 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 11:19:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b43aab528ed213e8d0e0a372b36832fc8ad5d06
Cr-Commit-Position: refs/heads/master@{#38610}

Powered by Google App Engine
This is Rietveld 408576698