Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2235313004: Revert of Bluetooth: mac: Crash while loging nil error. (Closed)

Created:
4 years, 4 months ago by kolos1
Modified:
4 years, 4 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bluetooth: mac: Crash while loging nil error. (patchset #4 id:60001 of https://codereview.chromium.org/2221353002/ ) Reason for revert: This CL breaks BluetoothTest.BluetoothGattConnection_SimulateDisconnect and BluetoothTest.BluetoothGattConnection_DisconnectGatt_SimulateDisconnect on on Mac10.11 and Mac10.10 See crbug.com/637216 Original issue's description: > Bluetooth: mac: Crash while loging nil error. > > Should not log error if no error. > > BUG=625209 > > Committed: https://crrev.com/e56593588554cf77aeab9bdab380ea80a7553057 > Cr-Commit-Position: refs/heads/master@{#411373} TBR=ortuno@chromium.org,fbeaufort@chromium.org,jlebel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=625209 Committed: https://crrev.com/72a052a67d9de03e88035bf98dcebeb19c00b1da Cr-Commit-Position: refs/heads/master@{#411580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M device/bluetooth/bluetooth_adapter_mac.mm View 2 chunks +11 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of Bluetooth: mac: Crash while loging nil error.
4 years, 4 months ago (2016-08-12 08:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235313004/1
4 years, 4 months ago (2016-08-12 08:24:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 08:25:36 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 08:28:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72a052a67d9de03e88035bf98dcebeb19c00b1da
Cr-Commit-Position: refs/heads/master@{#411580}

Powered by Google App Engine
This is Rietveld 408576698