Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2235313003: Do not sync the ARC++ opt-in preference. (Closed)

Created:
4 years, 4 months ago by dspaid
Modified:
4 years, 4 months ago
Reviewers:
hidehiko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Do not sync the ARC++ opt-in preference. This is a re-implementation of 1c7841e8e0322b8c3599710e017ff0fb38ab056f, which made ARC opt-in preference not synced. That change also stopped sending UMA stats due to not calling the OnSyncedPrefChanged method. BUG=633017 TEST=browser_tests --gtest_filter=ArcAuthServiceTest.* Additionally manually tested that the normal opt-in/opt-out process worked as expected. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2206883002 Cr-Commit-Position: refs/heads/master@{#410994} (cherry picked from commit 176f6733ab5bdf6de91f08e840b814cf76b910bb)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dspaid
This is the CP for the patch you reviewed the other day.
4 years, 4 months ago (2016-08-12 05:47:21 UTC) #2
hidehiko
lgtm
4 years, 4 months ago (2016-08-12 12:08:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235313003/1
4 years, 4 months ago (2016-08-14 22:53:50 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-08-14 22:53:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235313003/1
4 years, 4 months ago (2016-08-14 23:00:23 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-14 23:03:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698