Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html

Issue 22353013: [CSS Grid Layout] Unknown grid area should compute to 'auto' (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html b/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
similarity index 52%
copy from LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html
copy to LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
index fccc8ab4097d422929bc0ca33e3604699d9f8d38..0a7e4ab30cd9a22b4f5c7cfeeaf876f715eba43f 100644
--- a/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html
+++ b/LayoutTests/fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
@@ -3,61 +3,61 @@
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
- grid-definition-rows: "firstRow" 10px 20px;
- grid-definition-columns: "firstColumn" 30px 40px;
+ grid-definition-rows: 10px 20px;
+ grid-definition-columns: 30px 40px;
grid-auto-flow: row;
}
-.bothSpanRow {
+.bothNamedGridLineRow {
+ grid-row: nonExistentArea / nonExistentArea;
grid-column: 1;
- grid-row: span 5 "firstRow" / span 1;
}
-.bothSpanColumn {
- grid-column: span / span 3;
+.bothNamedGridLineColumn {
grid-row: 1;
+ grid-column: nonExistentArea / span 3;
}
-.spanAutoRow {
+.namedGridLineSpanRow {
+ grid-row: nonExistentArea / span 5 "firstRow";
grid-column: 1;
- grid-row: span 5 "firstRow" / auto;
}
-.spanAutoColumn {
- grid-column: span / auto;
+.namedGridLineSpanColumn {
grid-row: 1;
+ grid-column: nonExistentArea / span;
}
</style>
<script src="../../resources/check-layout.js"></script>
<body onload="checkLayout('.grid')">
-<p>This test checks that we resolve 2 opposite 'span' / 'auto' positions by applying the auto-placement algorithm.</p>
+<p>This test checks that unknown named area are treated as 'auto' by applying the auto-placement algorithm when mandated.</p>
<div style="position: relative">
<div class="grid">
<div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="30" data-expected-height="10"></div>
- <div class="sizedToGridArea bothSpanRow" data-offset-x="0" data-offset-y="10" data-expected-width="30" data-expected-height="20"></div>
+ <div class="sizedToGridArea bothNamedGridLineRow" data-offset-x="0" data-offset-y="10" data-expected-width="30" data-expected-height="20"></div>
</div>
</div>
<div style="position: relative">
<div class="grid">
<div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="30" data-expected-height="10"></div>
- <div class="sizedToGridArea bothSpanColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>
+ <div class="sizedToGridArea bothNamedGridLineColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>
</div>
</div>
<div style="position: relative">
<div class="grid">
<div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="30" data-expected-height="10"></div>
- <div class="sizedToGridArea spanAutoRow" data-offset-x="0" data-offset-y="10" data-expected-width="30" data-expected-height="20"></div>
+ <div class="sizedToGridArea namedGridLineSpanRow" data-offset-x="0" data-offset-y="10" data-expected-width="30" data-expected-height="20"></div>
</div>
</div>
<div style="position: relative">
<div class="grid">
<div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="30" data-expected-height="10"></div>
- <div class="sizedToGridArea spanAutoColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>
+ <div class="sizedToGridArea namedGridLineSpanColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="10"></div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698