Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 22353004: background-color and text-decoration are not preserved when merging paragraphs (Closed)

Created:
7 years, 4 months ago by grzegorz
Modified:
7 years, 4 months ago
Reviewers:
tony, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

background-color and text-decoration are not preserved when merging paragraphs In mergeInlineAndImplicitStyleOfElement(), the element styles are retrieved. If they contain either background-color or text-decoration they will be removed by removeNonEditingProperties() due to copyEditingProperties() implicit OnlyInheritableEditingProperties parameter. WebKit merge from r151772 and r152286 BUG=268922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155705

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
grzegorz
7 years, 4 months ago (2013-08-06 11:34:04 UTC) #1
tonyg
I suspect you are looking for tony@, not tonyg@.
7 years, 4 months ago (2013-08-06 17:59:21 UTC) #2
tony
This code LGTM, but why did you only import some of the cleanups in r152286?
7 years, 4 months ago (2013-08-06 18:06:19 UTC) #3
grzegorz
On 2013/08/06 18:06:19, tony wrote: > This code LGTM, but why did you only import ...
7 years, 4 months ago (2013-08-07 07:30:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/22353004/1
7 years, 4 months ago (2013-08-07 16:34:57 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 18:48:54 UTC) #6
Message was sent while issue was closed.
Change committed as 155705

Powered by Google App Engine
This is Rietveld 408576698