content/browser/renderer_host/render_widget_host_view_mac.h - Issue 2235283003: Track composition range and character bounds on the browser side (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2235283003: Track composition range and character bounds on the browser side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to fix some crashing tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.h

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h

index e9c8b683b34c229f67e09aa9a44435c306d0999a..6d647c7157bd88c14a01e5699820657d68a1f443 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.h

+++ b/content/browser/renderer_host/render_widget_host_view_mac.h

@@ -284,9 +284,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

void Focus() override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void ImeCompositionRangeChanged(

- const gfx::Range& range,

- const std::vector<gfx::Rect>& character_bounds) override;

void RenderProcessGone(base::TerminationStatus status,

int error_code) override;

void Destroy() override;

@@ -356,6 +353,9 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

bool did_update_state) override;

void OnImeCancelComposition(TextInputManager* text_input_manager,

RenderWidgetHostViewBase* updated_view) override;

+ void OnImeCompositionRangeChanged(

+ TextInputManager* text_input_manager,

+ RenderWidgetHostViewBase* updated_view) override;

// IPC::Sender implementation.

bool Send(IPC::Message* message) override;