content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2235283003: Track composition range and character bounds on the browser side (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2235283003: Track composition range and character bounds on the browser side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to fix some crashing tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 678f519a67a4fd12154592f58bea15e016b24e96..b5efbca882c000ca400e1dbbcab0da6c65a95299 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1490,11 +1490,12 @@ bool RenderWidgetHostViewAura::GetCompositionCharacterBounds(

if (!text_input_manager_ || !text_input_manager_->GetActiveWidget())

return false;

- const std::vector<gfx::Rect>* composition_character_bounds =

- text_input_manager_->GetCompositionCharacterBounds();

- if (index >= composition_character_bounds->size())

+ const TextInputManager::CompositionRangeInfo* composition_range_info =

+ text_input_manager_->GetCompositionRangeInfo();

+ if (index >= composition_range_info->character_bounds.size())

return false;

- *rect = ConvertRectToScreen(composition_character_bounds->at(index));

+ *rect = ConvertRectToScreen(composition_range_info->character_bounds[index]);

return true;

}