Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2235283003: Track composition range and character bounds on the browser side (Mac) (Closed)

Created:
4 years, 4 months ago by EhsanK
Modified:
4 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track composition range and character bounds on the browser side (Mac) This CL will route updates in composition range through TextInputManager on Mac. This is similar to how the tracking works in Aura. The corresponding test, 'TrackCompositionRangeForAllFrames' is also activated on Mac. BUG=578168, 602723 Committed: https://crrev.com/d773ff47652910acdd309eca657aec6133d513b1 Cr-Commit-Position: refs/heads/master@{#411732}

Patch Set 1 #

Patch Set 2 : Fixed a comment #

Patch Set 3 : Rebased to fix some crashing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -56 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 3 chunks +26 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.h View 1 2 3 chunks +15 lines, -11 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M content/public/test/text_input_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
EhsanK
PTAL. This should be that last CL for MAC-OOPIF-IME.
4 years, 4 months ago (2016-08-12 06:19:08 UTC) #12
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-12 15:56:04 UTC) #13
Charlie Reis
Great, LGTM too.
4 years, 4 months ago (2016-08-12 19:14:13 UTC) #14
kenrb
lgtm
4 years, 4 months ago (2016-08-12 19:14:56 UTC) #16
EhsanK
Thank you for the reviews. I will CQ after dry-run.
4 years, 4 months ago (2016-08-12 19:25:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235283003/40001
4 years, 4 months ago (2016-08-12 19:26:13 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 19:31:00 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:33:05 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d773ff47652910acdd309eca657aec6133d513b1
Cr-Commit-Position: refs/heads/master@{#411732}

Powered by Google App Engine
This is Rietveld 408576698