Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2235273003: [SVGDom] <polygon> & <polyline> support (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
CC:
reviews_skia.org, reed1
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : use SkPath::addPoly #

Patch Set 3 : GN build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -4 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttribute.h View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttributeParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttributeParser.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGDOM.cpp View 4 chunks +20 lines, -4 lines 0 comments Download
M experimental/svg/model/SkSVGNode.h View 1 chunk +2 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGPoly.h View 1 chunk +42 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGPoly.cpp View 1 1 chunk +36 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGTypes.h View 3 chunks +4 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
f(malita)
The state seals use polygon/polyline extensively, so this will make our SVG corpus look much ...
4 years, 4 months ago (2016-08-11 17:33:36 UTC) #2
f(malita)
Ping.
4 years, 4 months ago (2016-08-12 16:14:29 UTC) #11
robertphillips
lgtm
4 years, 4 months ago (2016-08-12 18:07:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235273003/40001
4 years, 4 months ago (2016-08-12 18:12:46 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:15:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5b31f321fcc3bb7f2ed7cf31ff4b03901228594b

Powered by Google App Engine
This is Rietveld 408576698