Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2235273002: Refactor embedded structures to top-level scope. (Closed)

Created:
4 years, 4 months ago by bcwhite
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor embedded structures to top-level scope. Extracting information structures will allow re-use for other kinds of tracking, such as history of how resources have been accessed. BUG=620813 Committed: https://crrev.com/e2f05c37732bfa7934aa1c84ab82e3f2c885d0b2 Cr-Commit-Position: refs/heads/master@{#411460}

Patch Set 1 #

Patch Set 2 : removed new ResourceData class (for later CL) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -296 lines) Patch
M base/debug/activity_analyzer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/debug/activity_analyzer_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M base/debug/activity_tracker.h View 1 8 chunks +168 lines, -160 lines 0 comments Download
M base/debug/activity_tracker.cc View 1 10 chunks +97 lines, -98 lines 0 comments Download
M base/debug/activity_tracker_unittest.cc View 10 chunks +18 lines, -27 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
bcwhite
4 years, 4 months ago (2016-08-11 17:24:29 UTC) #8
manzagop (departed)
lgtm for code shuffle. Thanks for the separate cl!
4 years, 4 months ago (2016-08-11 18:56:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235273002/40001
4 years, 4 months ago (2016-08-11 19:26:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276397)
4 years, 4 months ago (2016-08-11 21:38:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235273002/40001
4 years, 4 months ago (2016-08-11 22:54:05 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-12 00:04:29 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 00:08:22 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2f05c37732bfa7934aa1c84ab82e3f2c885d0b2
Cr-Commit-Position: refs/heads/master@{#411460}

Powered by Google App Engine
This is Rietveld 408576698