Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2235233003: Mechanical refactoring of component updater preference registration. (Closed)

Created:
4 years, 4 months ago by Sorin Jianu
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical refactoring of component updater preference registration. Bernhard, please I need an owner's review for chrome/browser/prefs/browser_prefs.cc TBR=waffles@chromium.org BUG=637163 Committed: https://crrev.com/ebcfc8dd24457fd99249e7e449a007b2362f82ba Cr-Commit-Position: refs/heads/master@{#411790}

Patch Set 1 #

Patch Set 2 : Updated comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
A chrome/browser/component_updater/component_updater_prefs.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/component_updater/component_updater_prefs.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Sorin Jianu
Bernhard, please I need an owner's review for chrome/browser/prefs/browser_prefs.cc Thank you!
4 years, 4 months ago (2016-08-12 02:34:55 UTC) #6
Sorin Jianu
Pam, could you please look at this change? I need an owner's approval to changes ...
4 years, 4 months ago (2016-08-12 17:23:15 UTC) #10
Bernhard Bauer
On 2016/08/12 17:23:15, Sorin Jianu wrote: > Pam, could you please look at this change? ...
4 years, 4 months ago (2016-08-12 21:43:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235233003/20001
4 years, 4 months ago (2016-08-12 21:53:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 21:57:44 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ebcfc8dd24457fd99249e7e449a007b2362f82ba Cr-Commit-Position: refs/heads/master@{#411790}
4 years, 4 months ago (2016-08-12 22:00:38 UTC) #17
waffles
4 years, 4 months ago (2016-08-16 19:56:01 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698