Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2395)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 22352002: Support test harness (text-only) tests w/o expected results. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: re-upload Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/test.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/test.py b/Tools/Scripts/webkitpy/layout_tests/port/test.py
index 71c256a2b718cfbf0bd245a75df8f6477dda98dc..79b9887334542c1a6dc995065367ecfbc7ac250e 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/test.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/test.py
@@ -101,8 +101,8 @@ class TestList(object):
#
# These numbers may need to be updated whenever we add or delete tests. This includes virtual tests.
#
-TOTAL_TESTS = 108
-TOTAL_SKIPS = 27
+TOTAL_TESTS = 112
+TOTAL_SKIPS = 28
UNEXPECTED_PASSES = 1
UNEXPECTED_FAILURES = 24
@@ -142,6 +142,10 @@ def unit_test_list():
expected_text="foo\n\n", actual_text="foo\n")
tests.add('failures/expected/newlines_with_excess_CR.html',
expected_text="foo\r\r\r\n", actual_text="foo\n")
+ tests.add('failures/expected/testharness.html',
+ actual_text='FAIL: assert fired\n', expected_text=None,
+ actual_image=None, expected_image=None,
+ actual_checksum=None)
tests.add('failures/expected/text.html', actual_text='text_fail-png')
tests.add('failures/expected/skip_text.html', actual_text='text diff')
tests.add('failures/flaky/text.html')
@@ -190,6 +194,10 @@ layer at (0,0) size 800x34
tests.add('passes/checksum_in_image.html',
expected_image='tEXtchecksum\x00checksum_in_image-checksum')
tests.add('passes/skipped/skip.html')
+ tests.add('passes/testharness.html',
+ actual_text='PASS: assert is fine\n', expected_text=None,
+ actual_image=None, expected_image=None,
+ actual_checksum=None)
# Note that here the checksums don't match but the images do, so this test passes "unexpectedly".
# See https://bugs.webkit.org/show_bug.cgi?id=69444 .
@@ -290,6 +298,7 @@ Bug(test) failures/expected/newlines_trailing.html [ Failure ]
Bug(test) failures/expected/newlines_with_excess_CR.html [ Failure ]
Bug(test) failures/expected/reftest.html [ ImageOnlyFailure ]
Bug(test) failures/expected/text.html [ Failure ]
+Bug(test) failures/expected/testharness.html [ Failure ]
Bug(test) failures/expected/timeout.html [ Timeout ]
Bug(test) failures/expected/keyboard.html [ WontFix ]
Bug(test) failures/expected/exception.html [ WontFix ]
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698