Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py - Issue 22352002: Support test harness (text-only) tests w/o expected results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

Issue 22352002: Support test harness (text-only) tests w/o expected results. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: re-upload Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | Tools/Scripts/webkitpy/layout_tests/models/test_failures.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py b/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

index c516a12d05ba64c84e77d335e5c860a04d9d6f21..590f00d0868fdfb555814a7e77682c06c56c120b 100644

--- a/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

@@ -48,7 +48,8 @@ def write_test_result(filesystem, port, results_directory, test_name, driver_out

# FIXME: Instead of this long 'if' block, each failure class might

# have a responsibility for writing a test result.

if isinstance(failure, (test_failures.FailureMissingResult,

- test_failures.FailureTextMismatch)):

+ test_failures.FailureTextMismatch,

+ test_failures.FailureTestHarnessAssertion)):

writer.write_text_files(driver_output.text, expected_driver_output.text)

writer.create_text_diff_and_write_result(driver_output.text, expected_driver_output.text)

elif isinstance(failure, test_failures.FailureMissingImage):