Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2235133003: [interpreter] Collect type feedback from bitwise binary ops handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed mapping kSignedSmall -> kSigned32 to kSignedSmall -> kSignedSmall. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/type-hint-analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index af07fb2d6efcfbe1f2129b9219f9d53ba2c81d25..5927f998f91ffeb66cbcad04e1d09a2ffe2f1e3b 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -1186,8 +1186,7 @@ BinaryOperationHint BytecodeGraphBuilder::GetBinaryOperationHint() {
}
void BytecodeGraphBuilder::VisitAdd() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->Add(hint));
+ BuildBinaryOp(javascript()->Add(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitSub() {
@@ -1195,48 +1194,39 @@ void BytecodeGraphBuilder::VisitSub() {
}
void BytecodeGraphBuilder::VisitMul() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->Multiply(hint));
+ BuildBinaryOp(javascript()->Multiply(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitDiv() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->Divide(hint));
+ BuildBinaryOp(javascript()->Divide(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitMod() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->Modulus(hint));
+ BuildBinaryOp(javascript()->Modulus(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitBitwiseOr() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->BitwiseOr(hint));
+ BuildBinaryOp(javascript()->BitwiseOr(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitBitwiseXor() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->BitwiseXor(hint));
+ BuildBinaryOp(javascript()->BitwiseXor(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitBitwiseAnd() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->BitwiseAnd(hint));
+ BuildBinaryOp(javascript()->BitwiseAnd(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitShiftLeft() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->ShiftLeft(hint));
+ BuildBinaryOp(javascript()->ShiftLeft(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitShiftRight() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->ShiftRight(hint));
+ BuildBinaryOp(javascript()->ShiftRight(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitShiftRightLogical() {
- BinaryOperationHint hint = BinaryOperationHint::kAny;
- BuildBinaryOp(javascript()->ShiftRightLogical(hint));
+ BuildBinaryOp(javascript()->ShiftRightLogical(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::BuildBinaryOpWithImmediate(const Operator* js_op) {
« no previous file with comments | « no previous file | src/compiler/type-hint-analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698