Stop ShouldServiceRequest from running callback

Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396
Committed: https://crrev.com/336f01e389835aad6280247dc1ae8eef3868f8d3
Cr-Commit-Position: refs/heads/master@{#411449}

[yhirano, 2016-08-11 01:42:18]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 01:43:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-11 02:34:13]

Description was changed from

==========
Stop ShouldServiceRequest from running callback

todo

BUG=603396
==========

to

==========
Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396
==========

[yhirano, 2016-08-11 02:34:13]

yhirano@chromium.org changed reviewers:
+ jam@chromium.org, mmenke@chromium.org

[yhirano, 2016-08-11 02:40:32]

Hi,

I'm planning to introduce move-only parameters to BeginRequest
and relatives at [1] including ContinuePendingBeginRequest and
AbortRequestBeforeItStarts. Hence I strongly want to call them from
the same function.

1: https://codereview.chromium.org/1970693002/

[commit-bot: I haz the power, 2016-08-11 03:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:29:06]

Dry run: This issue passed the CQ dry run.

[jam, 2016-08-11 18:00:48]

lgtm

[mmenke, 2016-08-11 20:11:17]

On 2016/08/11 18:00:48, jam wrote:
> lgtm

I'll defer to jam.  I don't see what this gets us - surely we'll want to invoke
the interceptor things when using mojo, too?

[yhirano, 2016-08-11 23:41:13]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:41:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:48:01]

Description was changed from

==========
Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396
==========

to

==========
Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396
==========

[commit-bot: I haz the power, 2016-08-11 23:48:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-11 23:49:47]

Description was changed from

==========
Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396
==========

to

==========
Stop ShouldServiceRequest from running callback

As a preparation for loading mojo migration, this CL stops ShouldServiceRequest
from running a callback. Instead, it merely returns a boolean
indicating whether it should serve the request.

This CL is a refactoring and doesn't change the behavior.

BUG=603396

Committed: https://crrev.com/336f01e389835aad6280247dc1ae8eef3868f8d3
Cr-Commit-Position: refs/heads/master@{#411449}
==========

[commit-bot: I haz the power, 2016-08-11 23:49:48]

Patchset 1 (id:??) landed as
https://crrev.com/336f01e389835aad6280247dc1ae8eef3868f8d3
Cr-Commit-Position: refs/heads/master@{#411449}

[yhirano, 2016-08-12 01:11:14]

On 2016/08/11 23:49:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/336f01e389835aad6280247dc1ae8eef3868f8d3
> Cr-Commit-Position: refs/heads/master@{#411449}

[yhirano, 2016-08-12 01:11:54]

On 2016/08/11 20:11:17, mmenke wrote:
> On 2016/08/11 18:00:48, jam wrote:
> > lgtm
> 
> I'll defer to jam.  I don't see what this gets us - surely we'll want to
invoke
> the interceptor things when using mojo, too?

I just want pass |url_loader_client| to both ContinuePendingBeginRequest and
AbortRequestBeforeSending.