Fix Loading text for settings-dropdown-menu

chrome/browser/resources/settings/controls/settings_dropdown_menu.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * The |name| is shown in the gui.  The |value| us use to set or compare with
  * the preference value.
  * @typedef {{
  *   name: string,
  *   value: (number|string)
@@ skipping 17 matching lines @@
  */
 Polymer({
   is: 'settings-dropdown-menu',
 
   properties: {
     /** A text label for the drop-down menu. */
     label: String,
 
     /**
      * List of options for the drop-down menu.
-     * @type {DropdownMenuOptionList}
+     * @type {!DropdownMenuOptionList}
      */
     menuOptions: {
       type: Array,
       value: function() { return []; },
     },
 
     /** Whether the dropdown menu should be disabled. */
     disabled: {
       type: Boolean,
       reflectToAttribute: true,
@@ skipping 64 matching lines @@
         this.selected_, this.pref);
     if (prefValue !== undefined)
       this.set('pref.value', prefValue);
   },
 
   /**
    * Updates the selected item when the pref or menuOptions change.
    * @private
    */
   updateSelected_: function() {
-    if (!this.pref)
+    if (!this.pref || !this.menuOptions.length)
       return;
     var prefValue = this.pref.value;
     var option = this.menuOptions.find(function(menuItem) {
       return menuItem.value == prefValue;
     });
     if (option == undefined)
       this.selected_ = this.notFoundValue_;
     else
       this.selected_ = Settings.PrefUtil.prefToString(this.pref);
   },
 
   /**
    * @param {string} selected
    * @return {boolean}
    * @private
    */
   isSelectedNotFound_: function(selected) {
-    return this.menuOptions && selected == this.notFoundValue_;
+    return this.menuOptions.length > 0 && selected == this.notFoundValue_;

[Dan Beam, 2016/08/11 00:18:23]

bummer

   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldDisableMenu_: function() {
     return this.disabled || !this.menuOptions.length;
   },
 });