Update NaCl GN toolchain definitions.

Update NaCl GN toolchain definitions.

Pulls Chrome build and build_override into nacl to get the new toolchain definitions.

Redefine the nacl_bootstrap_toolchain to use the new definition.

BUG=634446
TBR=bradnelson@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/105a5e3e176ee1122c1e2f3cdae8b570763d797c

[brettw, 2016-08-10 23:27:19]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-08-10 23:27:26]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:27:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:27:34]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[brettw, 2016-08-10 23:32:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:32:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:32:11]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2016-08-10 23:32:28]

lgtm

[brettw, 2016-08-10 23:32:50]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-08-10 23:32:53]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:33:01]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[brettw, 2016-08-10 23:34:12]

Description was changed from

==========
Update NaCl GN toolchain definitions.

Pulls Chrome build and build_override into nacl to get the new toolchain
definitions.

Redefine the nacl_bootstrap_toolchain to use the new definition.

BUG=634446
==========

to

==========
Update NaCl GN toolchain definitions.

Pulls Chrome build and build_override into nacl to get the new toolchain
definitions.

Redefine the nacl_bootstrap_toolchain to use the new definition.

BUG=634446
TBR=bradnelson@chromium.org
==========

[brettw, 2016-08-10 23:34:12]

brettw@chromium.org changed reviewers:
+ bradnelson@chromium.org

[brettw, 2016-08-10 23:34:26]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:34:32]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[bradnelson, 2016-08-11 00:20:13]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-08-11 00:20:13]

lgtm

[commit-bot: I haz the power, 2016-08-11 00:20:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:21:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:21:33]

Try jobs failed on following builders:
  nacl-arm_perf_panda on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/build...)
  nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_dbg/builds...)
  nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_opt/builds...)
  nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)
  nacl-mac_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_opt/build...)
  nacl-precise32_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/...)
  nacl-precise32_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_opt...)
  nacl-precise64_arm_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_arm_glibc_...)
  nacl-precise64_arm_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_arm_newlib...)
  nacl-precise64_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_glibc_opt/...)
  nacl-precise64_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_dbg...)
  nacl-precise64_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_opt...)
  nacl-precise_64-newlib-arm_qemu-pnacl on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-ar...)
  nacl-precise_64-newlib-x86_32-pnacl on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
  nacl-precise_64-newlib-x86_32-pnacl-spec on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
  nacl-precise_64-newlib-x86_64-pnacl on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
  nacl-precise_64-newlib-x86_64-pnacl-spec on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
  nacl-presubmit on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/782)

[brettw, 2016-08-11 18:02:21]

Put back build overrides

[brettw, 2016-08-11 18:02:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-11 18:02:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2235083002/#ps20001
(title: "Put back build overrides")

[commit-bot: I haz the power, 2016-08-11 18:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:03:57]

Try jobs failed on following builders:
  nacl-mac_arm_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_arm_newlib_opt/b...)
  nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_glibc_opt/builds...)
  nacl-mac_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_dbg/build...)
  nacl-mac_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_newlib_opt/build...)
  nacl-precise32_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/...)
  nacl-precise32_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_dbg...)
  nacl-precise64_arm_glibc_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_arm_glibc_...)
  nacl-win64_newlib_dbg on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_dbg/bui...)

[brettw, 2016-08-11 18:11:15]

Now with buildtools

[brettw, 2016-08-11 18:11:15]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-11 18:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2235083002/#ps40001
(title: "Now with buildtools")

[commit-bot: I haz the power, 2016-08-11 18:11:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:36:32]

Try jobs failed on following builders:
  nacl-win32_newlib_opt on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_newlib_opt/bui...)

[brettw, 2016-08-11 19:23:06]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:23:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:34:15]

Description was changed from

==========
Update NaCl GN toolchain definitions.

Pulls Chrome build and build_override into nacl to get the new toolchain
definitions.

Redefine the nacl_bootstrap_toolchain to use the new definition.

BUG=634446
TBR=bradnelson@chromium.org
==========

to

==========
Update NaCl GN toolchain definitions.

Pulls Chrome build and build_override into nacl to get the new toolchain
definitions.

Redefine the nacl_bootstrap_toolchain to use the new definition.

BUG=634446
TBR=bradnelson@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/105a5e3e1...
==========

[commit-bot: I haz the power, 2016-08-11 19:34:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/native_client/src/native_client/+/105a5e3e1...