Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 2235063002: Add create note palette action. (Closed)

Created:
4 years, 4 months ago by jdufault
Modified:
4 years, 4 months ago
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@app-runtime-changes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add create note palette action. The action is only visible if the default note-taking application is installed. Activating the action will open up the note-taking app. TEST=./out/Release/ash_unittests --gtest_filter=CreateNote* TBR=oshima@chromium.org BUG=616112 Committed: https://crrev.com/77dfb185da141c1cd558207b62f75cfb895b7f49 Cr-Commit-Position: refs/heads/master@{#413485}

Patch Set 1 : Initial upload #

Total comments: 8

Patch Set 2 : Comments and tests #

Total comments: 22

Patch Set 3 : Address comments #

Patch Set 4 : Pull MockPaletteToolDelegate into a separate file #

Total comments: 2

Patch Set 5 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -15 lines) Patch
M ash/ash.gyp View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M ash/ash_strings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ash/common/palette_delegate.h View 1 1 chunk +5 lines, -1 line 0 comments Download
A ash/common/system/chromeos/palette/mock_palette_tool_delegate.h View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A + ash/common/system/chromeos/palette/mock_palette_tool_delegate.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tool.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tool.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_tool_manager.cc View 1 chunk +11 lines, -5 lines 0 comments Download
A ash/common/system/chromeos/palette/tools/create_note_action.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A ash/common/system/chromeos/palette/tools/create_note_action.cc View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
A ash/common/system/chromeos/palette/tools/create_note_unittest.cc View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A ash/common/test/test_palette_delegate.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A ash/common/test/test_palette_delegate.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/palette_action_create_note.icon View 1 chunk +35 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/palette_action_create_note.1x.icon View 1 chunk +35 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons_sources.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 65 (45 generated)
jdufault
oshima@, PTAL. Thanks!
4 years, 4 months ago (2016-08-12 21:05:01 UTC) #26
jdufault
jamescook@, PTAL. Thanks! I've filed crbug.com/637447 against myself to add tests.
4 years, 4 months ago (2016-08-12 22:42:19 UTC) #28
James Cook
I would also like to see at least a basic test of this feature. You ...
4 years, 4 months ago (2016-08-12 23:58:55 UTC) #29
jdufault
https://codereview.chromium.org/2235063002/diff/50001/ash/common/system/chromeos/palette/palette_tool.cc File ash/common/system/chromeos/palette/palette_tool.cc (right): https://codereview.chromium.org/2235063002/diff/50001/ash/common/system/chromeos/palette/palette_tool.cc#newcode21 ash/common/system/chromeos/palette/palette_tool.cc:21: tool_manager->AddTool(base::WrapUnique(new CreateNoteAction(tool_manager))); On 2016/08/12 23:58:55, James Cook (slow reviews) ...
4 years, 4 months ago (2016-08-16 21:38:18 UTC) #32
James Cook
Just nits. Ping me on chat if you need the next patch turned around particularly ...
4 years, 4 months ago (2016-08-16 22:08:45 UTC) #33
James Cook
Also, please update the CL description to have a bit more detail and add a ...
4 years, 4 months ago (2016-08-16 22:10:17 UTC) #34
jdufault
https://codereview.chromium.org/2235063002/diff/70001/ash/common/system/chromeos/palette/palette_tool.cc File ash/common/system/chromeos/palette/palette_tool.cc (right): https://codereview.chromium.org/2235063002/diff/70001/ash/common/system/chromeos/palette/palette_tool.cc#newcode15 ash/common/system/chromeos/palette/palette_tool.cc:15: tool_manager->AddTool(base::MakeUnique<CreateNoteAction>(tool_manager)); On 2016/08/16 22:08:44, James Cook (slow reviews) wrote: ...
4 years, 4 months ago (2016-08-16 22:45:52 UTC) #38
James Cook
LGTM
4 years, 4 months ago (2016-08-16 22:48:16 UTC) #39
jdufault
estade@ PTAL at ui/*
4 years, 4 months ago (2016-08-17 19:38:40 UTC) #43
jdufault
On 2016/08/17 19:38:40, jdufault wrote: > estade@ PTAL at ui/* ping
4 years, 4 months ago (2016-08-19 19:20:56 UTC) #48
James Cook
On 2016/08/19 19:20:56, jdufault wrote: > On 2016/08/17 19:38:40, jdufault wrote: > > estade@ PTAL ...
4 years, 4 months ago (2016-08-19 20:43:04 UTC) #49
jdufault
On 2016/08/19 20:43:04, James Cook (slow reviews) wrote: > On 2016/08/19 19:20:56, jdufault wrote: > ...
4 years, 4 months ago (2016-08-19 21:25:02 UTC) #50
Evan Stade
lgtm https://codereview.chromium.org/2235063002/diff/110001/ash/common/system/chromeos/palette/tools/create_note_action.cc File ash/common/system/chromeos/palette/tools/create_note_action.cc (right): https://codereview.chromium.org/2235063002/diff/110001/ash/common/system/chromeos/palette/tools/create_note_action.cc#newcode16 ash/common/system/chromeos/palette/tools/create_note_action.cc:16: bool IsNoteAppAvailable() { why not just inline this ...
4 years, 4 months ago (2016-08-22 15:12:21 UTC) #51
jdufault
https://codereview.chromium.org/2235063002/diff/110001/ash/common/system/chromeos/palette/tools/create_note_action.cc File ash/common/system/chromeos/palette/tools/create_note_action.cc (right): https://codereview.chromium.org/2235063002/diff/110001/ash/common/system/chromeos/palette/tools/create_note_action.cc#newcode16 ash/common/system/chromeos/palette/tools/create_note_action.cc:16: bool IsNoteAppAvailable() { On 2016/08/22 15:12:21, Evan Stade wrote: ...
4 years, 4 months ago (2016-08-22 16:29:20 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235063002/130001
4 years, 4 months ago (2016-08-22 16:29:57 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/243022)
4 years, 4 months ago (2016-08-22 16:37:19 UTC) #57
jdufault
On 2016/08/22 16:37:19, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-22 16:42:18 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235063002/130001
4 years, 4 months ago (2016-08-22 16:43:05 UTC) #61
commit-bot: I haz the power
Committed patchset #5 (id:130001)
4 years, 4 months ago (2016-08-22 18:46:47 UTC) #63
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:48:40 UTC) #65
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/77dfb185da141c1cd558207b62f75cfb895b7f49
Cr-Commit-Position: refs/heads/master@{#413485}

Powered by Google App Engine
This is Rietveld 408576698