Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2235033002: [fuchsia] Update run_vm_tests_fuchsia for fuchsia launchpad API change (Closed)

Created:
4 years, 4 months ago by jamesr
Modified:
4 years, 4 months ago
Reviewers:
zra, kulakowski1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Update run_vm_tests_fuchsia for fuchsia launchpad API change R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/cfdd6ee5cc6a7af56ead91190af8f8dcc33e82ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/run_vm_tests_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jamesr
4 years, 4 months ago (2016-08-10 21:31:06 UTC) #2
zra
lgtm Would you like me to land this for you?
4 years, 4 months ago (2016-08-10 21:39:19 UTC) #3
jamesr
I can land this - we need to land a dependency in fuchsia-sdk first, so ...
4 years, 4 months ago (2016-08-10 22:04:24 UTC) #4
jamesr
4 years, 4 months ago (2016-08-10 22:41:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfdd6ee5cc6a7af56ead91190af8f8dcc33e82ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698