Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2235023002: Subzero: Elide redundant access checks within basic blocks (Closed)

Created:
4 years, 4 months ago by tlively
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Elide redundant access checks within basic blocks BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9b384977448d4396028b342ed96c490c1a69c391

Patch Set 1 #

Total comments: 1

Patch Set 2 : Turned asan runtime debug back off #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -26 lines) Patch
M runtime/szrt_asan.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceASanInstrumentation.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/IceASanInstrumentation.cpp View 2 chunks +19 lines, -0 lines 0 comments Download
M tests_lit/asan_tests/elidelocalchecks.ll View 4 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tlively
4 years, 4 months ago (2016-08-10 21:31:49 UTC) #1
tlively
4 years, 4 months ago (2016-08-10 21:32:37 UTC) #3
Karl
lgtm https://codereview.chromium.org/2235023002/diff/1/src/IceASanInstrumentation.cpp File src/IceASanInstrumentation.cpp (right): https://codereview.chromium.org/2235023002/diff/1/src/IceASanInstrumentation.cpp#newcode347 src/IceASanInstrumentation.cpp:347: else Nit: The typical style is to drop ...
4 years, 4 months ago (2016-08-11 14:51:17 UTC) #4
tlively
4 years, 4 months ago (2016-08-11 18:24:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9b384977448d4396028b342ed96c490c1a69c391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698