Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 2235013002: Revert runtime lowering of wasm SIMD ops (Closed)

Created:
4 years, 4 months ago by gdeepti
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert runtime lowering of wasm SIMD ops This CL reverts the runtime lowering introduced here - https://codereview.chromium.org/1991143002/ Additional ops to the runtime pass will cause GC issues as WASM frames may have outgoing arguments to runtime calls that have pointers that aren't scanned. Preserving decoding of SIMD opcodes and macros for native implementations. R=bbudge@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/fe555065ea53da31dc0e7b0920d7d6aee73403c7 Cr-Commit-Position: refs/heads/master@{#38564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -374 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compiler/simd-lowering.h View 1 chunk +0 lines, -46 lines 0 comments Download
D src/compiler/simd-lowering.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M src/compiler/wasm-compiler.h View 8 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 6 chunks +4 lines, -109 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/wasm/test-run-wasm-simd.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D test/mjsunit/wasm/test-wasm-simd-ops.js View 1 chunk +0 lines, -23 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
gdeepti
4 years, 4 months ago (2016-08-10 20:41:10 UTC) #5
bradnelson
lgtm, on to native!
4 years, 4 months ago (2016-08-10 21:22:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235013002/1
4 years, 4 months ago (2016-08-10 21:26:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21579)
4 years, 4 months ago (2016-08-10 21:28:59 UTC) #10
Mircea Trofin
On 2016/08/10 21:28:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-10 21:37:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235013002/1
4 years, 4 months ago (2016-08-10 21:37:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 21:39:13 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:39:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe555065ea53da31dc0e7b0920d7d6aee73403c7
Cr-Commit-Position: refs/heads/master@{#38564}

Powered by Google App Engine
This is Rietveld 408576698