Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2235003002: [LayoutNG] Add PRESUBMIT.py for layout/ng directory. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger, Gleb Lanbin, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add PRESUBMIT.py for layout/ng directory. Initially just has the format check. BUG=635619 Committed: https://crrev.com/85890ad97318cd7fc2554c2c0209ba6b908c91ac Cr-Commit-Position: refs/heads/master@{#411143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ikilpatrick
4 years, 4 months ago (2016-08-10 19:27:41 UTC) #2
ikilpatrick
4 years, 4 months ago (2016-08-10 19:31:44 UTC) #3
eae
LGTM
4 years, 4 months ago (2016-08-10 19:33:13 UTC) #4
cbiesinger
lgtm
4 years, 4 months ago (2016-08-10 19:33:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235003002/1
4 years, 4 months ago (2016-08-10 19:35:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 21:04:36 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:07:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85890ad97318cd7fc2554c2c0209ba6b908c91ac
Cr-Commit-Position: refs/heads/master@{#411143}

Powered by Google App Engine
This is Rietveld 408576698