Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 22350003: Add downsample from 8888 to 4444. (Closed)

Created:
7 years, 4 months ago by scroggo
Modified:
7 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add downsample from 8888 to 4444. Extend SkBitmap::copyTo to copy from a source with SkARGB_8888_Config to a destination bitmap with SkARGB_4444_Config. BUG=http://code.google.com/p/chromium/issues/detail?id=245774 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10621

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comments. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
A gm/copyTo4444.cpp View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 4 months ago (2013-08-07 18:25:05 UTC) #1
reed1
Can we create a simple gm for this? https://codereview.chromium.org/22350003/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/22350003/diff/1/src/core/SkBitmap.cpp#newcode1122 src/core/SkBitmap.cpp:1122: SkColor ...
7 years, 4 months ago (2013-08-07 18:30:03 UTC) #2
scroggo
> Can we create a simple gm for this? Done. https://codereview.chromium.org/22350003/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/22350003/diff/1/src/core/SkBitmap.cpp#newcode1122 ...
7 years, 4 months ago (2013-08-07 19:04:19 UTC) #3
reed1
lgtm
7 years, 4 months ago (2013-08-07 19:12:03 UTC) #4
scroggo
7 years, 4 months ago (2013-08-07 19:17:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r10621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698