third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html ('K') | « third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var.html » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html

diff --git a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html b/third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html

index 70d23e1aca3766069b9128b5fe5e4043be00c942..6f62f431df4ddbb69f71064455e92ab280938cfb 100644

--- a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html

+++ b/third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html

@@ -41,13 +41,13 @@ function test()

InspectorTest.RuntimeAgent.evaluate("object1", step1);

}

- function step1(error, result, wasThrown)

+ function step1(error, result)

dgozman 2016/08/11 01:54:36 While you are here, let's add exceptionDetails sec

kozy 2016/08/11 21:04:22 Done.

{

obj1 = InspectorTest.runtimeModel.createRemoteObject(result);

InspectorTest.RuntimeAgent.evaluate("object2", step2);

}

- function step2(error, result, wasThrown)

+ function step2(error, result)

dgozman 2016/08/11 01:54:35 While you are here, let's add exceptionDetails sec

kozy 2016/08/11 21:04:22 Done.

{

obj2 = InspectorTest.runtimeModel.createRemoteObject(result);

next();