third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html ('K') | « third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html ('k') | third_party/WebKit/LayoutTests/inspector/elements/resolve-node-blocked.html » ('j') | third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html b/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html

index 69d867df6428ae007a2de271ac3cdf8b2fbc3966..81f53292b084d441ff1e55c909bc707f5e0d9151 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html

@@ -7,7 +7,7 @@ function test()

{

InspectorTest.RuntimeAgent.evaluate("var doc = document.implementation.createHTMLDocument(''); doc.lastChild.innerHTML = '<span></span>'; doc.lastChild", step1);

- function step1(error, result, wasThrown)

+ function step1(error, result)

dgozman 2016/08/11 01:54:34 While you are here, let's add exceptionDetails sec

kozy 2016/08/11 21:04:21 Done.

{

var spanWrapper = InspectorTest.runtimeModel.createRemoteObject(result);

InspectorTest.domModel.pushObjectAsNodeToFrontend(spanWrapper, step2);