third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html - Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html

index 8fe5ce8e72571ec6f53b7cef7061c2daa8940b9c..5d7af0d59d938ff3edbe721947159e2493c756bd 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html

@@ -27,7 +27,7 @@ function test()

{

InspectorTest.RuntimeAgent.evaluate("window.objectId", dispatch);

- function dispatch(error, result, wasThrown)

dgozman 2016/08/11 01:54:34 While you are here, let's add exceptionDetails sec

kozy 2016/08/11 21:04:21 Done.

+ function dispatch(error, result)

{

if (result.type !== "string") {

InspectorTest.evaluateInPage("console.log('Opening front-end for the first time')");

@@ -42,7 +42,7 @@ function test()

{

InspectorTest.RuntimeAgent.evaluate("({ handle : \"handle\" })", storeIdInTargetWindow);

- function storeIdInTargetWindow(error, result, wasThrown)

+ function storeIdInTargetWindow(error, result)

dgozman 2016/08/11 01:54:34 While you are here, let's add exceptionDetails sec

kozy 2016/08/11 21:04:21 Done.

{

checkHandleInInjectedScript(result.objectId, reopenInspector);