Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2234983002: [DevTools] Removed wasThrown from evaluate-like protocol methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8DebuggerAgentImpl_h 5 #ifndef V8DebuggerAgentImpl_h
6 #define V8DebuggerAgentImpl_h 6 #define V8DebuggerAgentImpl_h
7 7
8 #include "platform/inspector_protocol/Collections.h" 8 #include "platform/inspector_protocol/Collections.h"
9 #include "platform/inspector_protocol/String16.h" 9 #include "platform/inspector_protocol/String16.h"
10 #include "platform/v8_inspector/JavaScriptCallFrame.h" 10 #include "platform/v8_inspector/JavaScriptCallFrame.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 void setPauseOnExceptions(ErrorString*, const String16& pauseState) override ; 104 void setPauseOnExceptions(ErrorString*, const String16& pauseState) override ;
105 void evaluateOnCallFrame(ErrorString*, 105 void evaluateOnCallFrame(ErrorString*,
106 const String16& callFrameId, 106 const String16& callFrameId,
107 const String16& expression, 107 const String16& expression,
108 const Maybe<String16>& objectGroup, 108 const Maybe<String16>& objectGroup,
109 const Maybe<bool>& includeCommandLineAPI, 109 const Maybe<bool>& includeCommandLineAPI,
110 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 110 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
111 const Maybe<bool>& returnByValue, 111 const Maybe<bool>& returnByValue,
112 const Maybe<bool>& generatePreview, 112 const Maybe<bool>& generatePreview,
113 std::unique_ptr<protocol::Runtime::RemoteObject>* result, 113 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
114 Maybe<bool>* wasThrown,
115 Maybe<protocol::Runtime::ExceptionDetails>*) override; 114 Maybe<protocol::Runtime::ExceptionDetails>*) override;
116 void setVariableValue(ErrorString*, 115 void setVariableValue(ErrorString*,
117 int scopeNumber, 116 int scopeNumber,
118 const String16& variableName, 117 const String16& variableName,
119 std::unique_ptr<protocol::Runtime::CallArgument> newValue, 118 std::unique_ptr<protocol::Runtime::CallArgument> newValue,
120 const String16& callFrame) override; 119 const String16& callFrame) override;
121 void setAsyncCallStackDepth(ErrorString*, int depth) override; 120 void setAsyncCallStackDepth(ErrorString*, int depth) override;
122 void setBlackboxPatterns(ErrorString*, 121 void setBlackboxPatterns(ErrorString*,
123 std::unique_ptr<protocol::Array<String16>> patterns) override; 122 std::unique_ptr<protocol::Array<String16>> patterns) override;
124 void setBlackboxedRanges(ErrorString*, 123 void setBlackboxedRanges(ErrorString*,
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 bool m_skipAllPauses; 213 bool m_skipAllPauses;
215 214
216 std::unique_ptr<V8Regex> m_blackboxPattern; 215 std::unique_ptr<V8Regex> m_blackboxPattern;
217 protocol::HashMap<String16, std::vector<std::pair<int, int>>> m_blackboxedPo sitions; 216 protocol::HashMap<String16, std::vector<std::pair<int, int>>> m_blackboxedPo sitions;
218 }; 217 };
219 218
220 } // namespace blink 219 } // namespace blink
221 220
222 221
223 #endif // V8DebuggerAgentImpl_h 222 #endif // V8DebuggerAgentImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698