[DevTools] Removed wasThrown from evaluate-like protocol methods

third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 642 matching lines @@
         if (!this._objectId) {
             callback("Can't set a property of non-object.");
             return;
         }
 
         this._runtimeAgent.invoke_evaluate({expression:value, doNotPauseOnExceptionsAndMuteConsole:true}, evaluatedCallback.bind(this));
 
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
          * @this {WebInspector.RemoteObject}
          */
-        function evaluatedCallback(error, result, wasThrown)
+        function evaluatedCallback(error, result, exceptionDetails)

[dgozman, 2016/08/11 01:54:36]

Could you please check why compiler didn't catch missing arguments before?

[kozy, 2016/08/11 21:04:22]

Compiler allows to omit optional arguments in callbacks.

         {
-            if (error || wasThrown) {
+            if (error || !!exceptionDetails) {
                 callback(error || (result.type !== "string" ? result.description : /** @type {string} */(result.value)));
                 return;
             }
 
             if (typeof name === "string")
                 name = WebInspector.RemoteObject.toCallArgument(name);
 
             this.doSetObjectPropertyValue(result, name, callback);
 
             if (result.objectId)
@@ skipping 13 matching lines @@
         // but logically it is bound to the object in question. JavaScript passes this object to getters/setters, not the object
         // where property was defined; so do we.
         var setPropertyValueFunction = "function(a, b) { this[a] = b; }";
 
         var argv = [name, WebInspector.RemoteObject.toCallArgument(result)];
         this._runtimeAgent.callFunctionOn(this._objectId, setPropertyValueFunction, argv, true, undefined, undefined, undefined, undefined, propertySetCallback);
 
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
          */
-        function propertySetCallback(error, result, wasThrown)
+        function propertySetCallback(error, result, exceptionDetails)
         {
-            if (error || wasThrown) {
+            if (error || !!exceptionDetails) {
                 callback(error || result.description);
                 return;
             }
             callback();
         }
     },
 
     /**
      * @override
      * @param {!RuntimeAgent.CallArgument} name
      * @param {function(string=)} callback
      */
     deleteProperty: function(name, callback)
     {
         if (!this._objectId) {
             callback("Can't delete a property of non-object.");
             return;
         }
 
         var deletePropertyFunction = "function(a) { delete this[a]; return !(a in this); }";
         this._runtimeAgent.callFunctionOn(this._objectId, deletePropertyFunction, [name], true, undefined, undefined, undefined, undefined, deletePropertyCallback);
 
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
          */
-        function deletePropertyCallback(error, result, wasThrown)
+        function deletePropertyCallback(error, result, exceptionDetails)
         {
-            if (error || wasThrown) {
+            if (error || !!exceptionDetails) {
                 callback(error || result.description);
                 return;
             }
             if (!result.value)
                 callback("Failed to delete property.");
             else
                 callback();
         }
     },
 
     /**
      * @override
      * @param {function(this:Object, ...)} functionDeclaration
      * @param {!Array.<!RuntimeAgent.CallArgument>=} args
      * @param {function(?WebInspector.RemoteObject, boolean=)=} callback
      */
     callFunction: function(functionDeclaration, args, callback)
     {
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
          * @this {WebInspector.RemoteObjectImpl}
          */
-        function mycallback(error, result, wasThrown)
+        function mycallback(error, result, exceptionDetails)
         {
             if (!callback)
                 return;
             if (error)
                 callback(null, false);
             else
-                callback(this.target().runtimeModel.createRemoteObject(result), wasThrown);
+                callback(this.target().runtimeModel.createRemoteObject(result), !!exceptionDetails);
         }
 
         this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, undefined, undefined, undefined, undefined, mycallback.bind(this));
     },
 
     /**
      * @override
      * @param {function(this:Object)} functionDeclaration
      * @param {!Array.<!RuntimeAgent.CallArgument>|undefined} args
      * @param {function(*)} callback
      */
     callFunctionJSON: function(functionDeclaration, args, callback)
     {
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
-         * @param {boolean=} wasThrown
+         * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
          */
-        function mycallback(error, result, wasThrown)
+        function mycallback(error, result, exceptionDetails)
         {
-            callback((error || wasThrown) ? null : result.value);
+            callback((error || !!exceptionDetails) ? null : result.value);
         }
 
         this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, true, false, undefined, undefined, mycallback);
     },
 
     release: function()
     {
         if (!this._objectId)
             return;
         this._runtimeAgent.releaseObject(this._objectId);
@@ skipping 710 matching lines @@
     },
 
     /**
      * @return {!WebInspector.RemoteObject}
      */
     object: function()
     {
         return this._object;
     }
 }