Issue 2234903002: Check for the existence of goma before trying to use it

Issue 2234903002: Check for the existence of goma before trying to use it (Closed)

Created:
4 years, 4 months ago by Derek Schuff

Modified:
4 years, 4 months ago

Reviewers:
bradnelson

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Check for the existence of goma before trying to use it Some of the trybots do not have goma; fall back to local compiler if goma isn't found. R=bradnelson@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/c871b6d1c5d916d5868fb47bb01ef56966b7828d

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	buildbot/buildbot_pnacl_toolchain.py	View	1	5 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

Derek Schuff

The other option would be to remove the support entirely, or to figure out the ...

4 years, 4 months ago (2016-08-10 15:58:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234903002/20001

4 years, 4 months ago (2016-08-10 16:15:12 UTC) #4

commit-bot: I haz the power

4 years, 4 months ago (2016-08-10 17:11:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/c871b6d1c...