components/offline_pages/offline_page_model_impl.cc - Issue 2234873004: Have the RequestCoordinator generate the offline_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile warning about const Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/prerendering_offliner.h ('K') | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/offline_page_model_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.cc

diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc

index c97b2967fb1ec9798c93c2e239f6d509caf630da..5260b4633ea520e79f952080a1fd7a5d7a57da0b 100644

--- a/components/offline_pages/offline_page_model_impl.cc

+++ b/components/offline_pages/offline_page_model_impl.cc

@@ -274,6 +274,7 @@ void OfflinePageModelImpl::RemoveObserver(Observer* observer) {

void OfflinePageModelImpl::SavePage(

const GURL& url,

const ClientId& client_id,

+ int64_t offline_id,

std::unique_ptr<OfflinePageArchiver> archiver,

const SavePageCallback& callback) {

DCHECK(is_loaded_);

@@ -293,7 +294,9 @@ void OfflinePageModelImpl::SavePage(

return;

}

- int64_t offline_id = GenerateOfflineId();

+ // If we already have an offline id, use it. If not, generate one.

+ if (offline_id == 0ul)

Dmitry Titov 2016/08/16 02:25:00 This should go into the comment for SavePage metho

Pete Williamson 2016/08/16 18:54:56 Done.

+ offline_id = GenerateOfflineId();

archiver->CreateArchive(

archives_dir_, offline_id,