Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5419)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2234873004: Have the RequestCoordinator generate the offline_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile warning about const Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 83d09d06b4add1aa5b7174ebfcaf19d8390b2c71..61e60d2e3829e7c74183c7391bdb50e665f991cd 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -53,6 +53,7 @@ class PrerenderingOffliner : public Offliner {
// TODO(dougarnett): Consider making OfflinePageModel mockable instead.
virtual void SavePage(const GURL& url,
const ClientId& client_id,
+ int64_t offline_id,
Dmitry Titov 2016/08/16 02:25:00 Naming suggestion: maybe proposed_offline_id? To c
Pete Williamson 2016/08/16 18:54:56 Done.
std::unique_ptr<OfflinePageArchiver> archiver,
const SavePageCallback& save_callback);

Powered by Google App Engine
This is Rietveld 408576698