Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2234873002: git cl set-commit: actually apply passed --rietveld / --gerrit options (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl set-commit: actually apply passed --rietveld / --gerrit options BUG=600945 Recipe-Tryjob-Bypass-Reason: expectation changes expected and wanted Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7c3841abdfddcb33f25be98d20c9e9db70657f9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
tandrii(chromium)
LGTM, this is indeedn an oversight. *But* how did you find this? AFAIU, the only ...
4 years, 4 months ago (2016-08-10 15:04:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234873002/1
4 years, 4 months ago (2016-08-10 15:17:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: build-internal-recipe-downstream-tryjob on master.internal.infra.try (JOB_FAILED, https://uberchromegw.corp.google.com/i/internal.infra.try/builders/build-internal-recipe-downstream-tryjob/builds/2503)
4 years, 4 months ago (2016-08-10 15:28:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234873002/1
4 years, 4 months ago (2016-08-10 16:30:52 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:35:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7c3841abdfddcb...

Powered by Google App Engine
This is Rietveld 408576698