[SVGDom] Add rx/ry support for <rect>

[SVGDom] Add rx/ry support for <rect>

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234863002

Committed: https://skia.googlesource.com/skia/+/286a8657da0364006e95cb0988477cc3a5f0e112

[f(malita), 2016-08-10 14:36:28]

Description was changed from

==========
[SVGDom] Add rx/ry support for <rect>

R=stephana@google.com,robertphillips@google.com
==========

to

==========
[SVGDom] Add rx/ry support for <rect>

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234863002
==========

[f(malita), 2016-08-10 14:38:09]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-10 14:53:07]

lgtm

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttribute.h:19: kHeight,
// The x radius for round rects ?

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttribute.h:20: kRx,
// The y radius for round rects ?

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRect.h (right):

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRect.h:13: 
Should this be SkSVGRRect since the rect case is just a special case of the
rrect ?

[f(malita), 2016-08-10 15:02:52]

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGAttribute.h (right):

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttribute.h:19: kHeight,
On 2016/08/10 14:53:06, robertphillips wrote:
> // The x radius for round rects ?

Done.

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttribute.h:20: kRx,
On 2016/08/10 14:53:06, robertphillips wrote:
> // The y radius for round rects ?

Done.

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRect.h (right):

https://codereview.chromium.org/2234863002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRect.h:13: 
On 2016/08/10 14:53:06, robertphillips wrote:
> Should this be SkSVGRRect since the rect case is just a special case of the
> rrect ?

I don't feel strongly about it, but so far I've been trying to maintain class
name<->SVG name correspondence - and the SVG element name is <rect>.  

Maybe we should rename element-related classes to SkSVGFoo*Element* or
SkSVGFoo*Node* to make this clear?

[f(malita), 2016-08-10 23:32:50]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-10 23:32:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2234863002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-08-10 23:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:11:31]

Description was changed from

==========
[SVGDom] Add rx/ry support for <rect>

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234863002
==========

to

==========
[SVGDom] Add rx/ry support for <rect>

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234863002

Committed:
https://skia.googlesource.com/skia/+/286a8657da0364006e95cb0988477cc3a5f0e112
==========

[commit-bot: I haz the power, 2016-08-11 00:11:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/286a8657da0364006e95cb0988477cc3a5f0e112