[LayoutNG] Add base class for NGFragment and NGText

[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org

Committed: https://crrev.com/b32fa3906f2e3e5254d07497fe95806b6e0c01ba
Cr-Commit-Position: refs/heads/master@{#411102}

[eae, 2016-08-10 15:13:42]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 15:14:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-10 15:16:45]

Description was changed from

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment & NGRText inherits
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org
==========

to

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org
==========

[eae, 2016-08-10 15:17:47]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 15:18:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-10 15:19:53]

lgtm

[commit-bot: I haz the power, 2016-08-10 15:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:22:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[eae, 2016-08-10 15:22:24]

Thanks. Based on the CSSValue setup to avoid having a vtable. We'll obviously
have the oilpan team take a look at this later.

[eae, 2016-08-10 16:19:59]

The CQ bit was checked by eae@chromium.org

[eae, 2016-08-10 16:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2234833003/#ps40001
(title: "Add trace implementation")

[commit-bot: I haz the power, 2016-08-10 16:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 16:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:33:21]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eae, 2016-08-10 16:37:03]

The CQ bit was checked by eae@chromium.org

[eae, 2016-08-10 16:37:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2234833003/#ps60001
(title: "Add cc file to gypi")

[commit-bot: I haz the power, 2016-08-10 16:37:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 16:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:48:19]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[eae, 2016-08-10 17:10:24]

Patchset #4 (id:60001) has been deleted

[eae, 2016-08-10 17:10:30]

The CQ bit was checked by eae@chromium.org

[eae, 2016-08-10 17:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2234833003/#ps80001
(title: "Add ng_fragment_base.cc to gypi")

[commit-bot: I haz the power, 2016-08-10 17:11:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:44:11]

Description was changed from

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org
==========

to

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org
==========

[commit-bot: I haz the power, 2016-08-10 18:44:13]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-10 18:47:23]

Description was changed from

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org
==========

to

==========
[LayoutNG] Add base class for NGFragment and NGText

Adds a new NGFragmentBase class that both NGFragment and NGText inherit
from and change the NGFragment children collection to use this new base
class, thus allowing either NGFragment or NGText nodes.

BUG=635619
R=cbiesinger@chromium.org

Committed: https://crrev.com/b32fa3906f2e3e5254d07497fe95806b6e0c01ba
Cr-Commit-Position: refs/heads/master@{#411102}
==========

[commit-bot: I haz the power, 2016-08-10 18:47:25]

Patchset 4 (id:??) landed as
https://crrev.com/b32fa3906f2e3e5254d07497fe95806b6e0c01ba
Cr-Commit-Position: refs/heads/master@{#411102}