Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: base/message_loop/message_pump_observer.h

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-r262009 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/message_loop/message_pump_x11.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_observer.h
diff --git a/base/message_loop/message_pump_observer.h b/base/message_loop/message_pump_observer.h
index 333a75f1cbb4be2eafec08beb32e7ab924049004..1e8a7f53166e4971a0fb37e6ecae904c3a81ad04 100644
--- a/base/message_loop/message_pump_observer.h
+++ b/base/message_loop/message_pump_observer.h
@@ -10,13 +10,6 @@
namespace base {
-enum EventStatus {
- EVENT_CONTINUE, // The event should be dispatched as normal.
-#if defined(USE_X11)
- EVENT_HANDLED // The event should not be processed any farther.
-#endif
-};
-
// A MessagePumpObserver is an object that receives global
// notifications from the UI MessageLoop with MessagePumpWin or
// MessagePumpX11.
@@ -27,15 +20,10 @@ enum EventStatus {
// info about how this is invoked in this environment.
class BASE_EXPORT MessagePumpObserver {
public:
- // This method is called before processing a NativeEvent. If the
- // method returns EVENT_HANDLED, it indicates the event has already
- // been handled, so the event is not processed any farther. If the
- // method returns EVENT_CONTINUE, the event dispatching proceeds as
- // normal.
- virtual EventStatus WillProcessEvent(const NativeEvent& event) = 0;
-
- // This method is called after processing a message. This method
- // will not be called if WillProcessEvent returns EVENT_HANDLED.
+ // This method is called before processing a NativeEvent.
+ virtual void WillProcessEvent(const NativeEvent& event) = 0;
+
+ // This method is called after processing a message.
virtual void DidProcessEvent(const NativeEvent& event) = 0;
protected:
« no previous file with comments | « no previous file | base/message_loop/message_pump_x11.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698