Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: ui/base/clipboard/clipboard_aurax11.cc

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/clipboard/clipboard_aurax11.cc
diff --git a/ui/base/clipboard/clipboard_aurax11.cc b/ui/base/clipboard/clipboard_aurax11.cc
index 70768444b0cc4dc5b0ec78746b86291f68950b1a..41e0b0ede3825ab9935157598e8f955538092909 100644
--- a/ui/base/clipboard/clipboard_aurax11.cc
+++ b/ui/base/clipboard/clipboard_aurax11.cc
@@ -71,8 +71,7 @@ class SelectionChangeObserver : public base::MessagePumpObserver {
virtual ~SelectionChangeObserver();
// Overridden from base::MessagePumpObserver:
- virtual base::EventStatus WillProcessEvent(
- const base::NativeEvent& event) OVERRIDE;
+ virtual void WillProcessEvent(const base::NativeEvent& event) OVERRIDE;
virtual void DidProcessEvent(
const base::NativeEvent& event) OVERRIDE {}
@@ -118,8 +117,7 @@ SelectionChangeObserver* SelectionChangeObserver::GetInstance() {
return Singleton<SelectionChangeObserver>::get();
}
-base::EventStatus SelectionChangeObserver::WillProcessEvent(
- const base::NativeEvent& event) {
+void SelectionChangeObserver::WillProcessEvent(const base::NativeEvent& event) {
if (event->type == event_base_ + XFixesSelectionNotify) {
XFixesSelectionNotifyEvent* ev =
reinterpret_cast<XFixesSelectionNotifyEvent*>(event);
@@ -131,7 +129,6 @@ base::EventStatus SelectionChangeObserver::WillProcessEvent(
DLOG(ERROR) << "Unexpected selection atom: " << ev->selection;
}
}
- return base::EVENT_CONTINUE;
}
///////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698