Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2234823002: SVG tool that downloads SVGs from a txt file into a specified dir (Closed)

Created:
4 years, 4 months ago by rmistry
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SVG tool that downloads SVGs from a txt file into a specified dir BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234823002 Committed: https://skia.googlesource.com/skia/+/d8a620b173113f73ec708bcd2f56d4c2b2bba60c

Patch Set 1 : Initial upload #

Patch Set 2 : Minor fixes #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
A tools/svg/README.md View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tools/svg/svg_downloader.py View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A tools/svg/svgs.txt View 1 chunk +69 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
rmistry
4 years, 4 months ago (2016-08-10 13:17:07 UTC) #3
borenet
LGTM https://codereview.chromium.org/2234823002/diff/20001/tools/svg/svg_downloader.py File tools/svg/svg_downloader.py (right): https://codereview.chromium.org/2234823002/diff/20001/tools/svg/svg_downloader.py#newcode30 tools/svg/svg_downloader.py:30: default='svgs.txt') Can we make the default correctly determine ...
4 years, 4 months ago (2016-08-10 13:27:53 UTC) #4
rmistry
https://codereview.chromium.org/2234823002/diff/20001/tools/svg/svg_downloader.py File tools/svg/svg_downloader.py (right): https://codereview.chromium.org/2234823002/diff/20001/tools/svg/svg_downloader.py#newcode30 tools/svg/svg_downloader.py:30: default='svgs.txt') On 2016/08/10 13:27:53, borenet wrote: > Can we ...
4 years, 4 months ago (2016-08-10 13:36:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234823002/40001
4 years, 4 months ago (2016-08-10 13:41:12 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:00:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d8a620b173113f73ec708bcd2f56d4c2b2bba60c

Powered by Google App Engine
This is Rietveld 408576698