Issue 22348004: Refactor ShelfLayoutManager in preparation for fixing crbug.com/268209

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22348004: Refactor ShelfLayoutManager in preparation for fixing crbug.com/268209 (Closed)

Created:
7 years, 4 months ago by pkotwicz

Modified:
7 years, 4 months ago

Reviewers:
James Cook, sadrul

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Refactor ShelfLayoutManager in preparation for fixing crbug.com/268209 No functional changes. - Move ShelfLayoutManager::SetDimsShelf() after the State::Equals() call now that State::window_state exists. (Added in https://chromiumcodereview.appspot.com/18637004) - Use TargetBounds::status_opacity in ShelfLayoutManager::LayoutShelf() for the status opacity - Remove dead code in computing |delay_background_change|. (Added in https://chromiumcodereview.appspot.com/10911172) BUG=None Test=None R=sadrul TBR=jamescook Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216753