convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285
Committed: https://crrev.com/54a8f9a2dd2cdc8768220d60e6dd369ff05378c5
Cr-Commit-Position: refs/heads/master@{#411289}

[MuVen, 2016-08-10 11:43:32]

Description was changed from

==========
-a

done

BUG=
==========

to

==========
convert js-test.js to testharness.js in LayoutTest/scrollbars/* folder

BUG=636285
==========

[MuVen, 2016-08-10 11:43:33]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org, srirama.m@samsung.com

[MuVen, 2016-08-10 11:44:02]

PTAL

[Srirama, 2016-08-10 12:00:25]

LGTM with the comments addressed and approval from skobes.

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/scrollbars/drag-rtl-resizer.html (right):

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/drag-rtl-resizer.html:23:
assert_greater_than(document.getElementById('overflow').offsetWidth,
offsetWidth);
nit: you can use node.offsetWidth here.

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html
(right):

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html:5:
<input id='textField' type='text' style="position:relative;"> <br>
nit: space after ":" here and below

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html:11:
document.getElementById("textField").focus();
may be use querySelector her and remove id from input.

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html:21:
assert_true(window.frames[0].document.hasFocus());
take iframe.contentDocument in a variable and use it here and above.

[MuVen, 2016-08-10 12:30:31]

Addressed Review Comments, @skobes, PTAL.

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html
(right):

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html:5:
<input id='textField' type='text' style="position:relative;"> <br>
On 2016/08/10 12:00:25, Srirama wrote:
> nit: space after ":" here and below

Done.

https://codereview.chromium.org/2234773003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollbars/scrollable-iframe-click-gets-focus.html:11:
document.getElementById("textField").focus();
On 2016/08/10 12:00:25, Srirama wrote:
> may be use querySelector her and remove id from input.

Done.

[MuVen, 2016-08-10 12:31:54]

Description was changed from

==========
convert js-test.js to testharness.js in LayoutTest/scrollbars/* folder

BUG=636285
==========

to

==========
convert LayoutTest/scrollbars/* js-test.js tests to testhearness.js based tests.

BUG=636285
==========

[skobes, 2016-08-10 21:14:43]

typo in description - "testhearness" -> "testharness"

otherwise lgtm

[MuVen, 2016-08-11 02:13:43]

Description was changed from

==========
convert LayoutTest/scrollbars/* js-test.js tests to testhearness.js based tests.

BUG=636285
==========

to

==========
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285
==========

[MuVen, 2016-08-11 06:56:47]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2016-08-11 06:56:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
srirama.m@samsung.com
Link to the patchset: https://codereview.chromium.org/2234773003/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-08-11 06:56:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-08-11 06:57:09]

On 2016/08/10 21:14:43, skobes wrote:
> typo in description - "testhearness" -> "testharness"
> 
> otherwise lgtm

Done, Changed Description.

[commit-bot: I haz the power, 2016-08-11 08:04:33]

Description was changed from

==========
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285
==========

to

==========
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285
==========

[commit-bot: I haz the power, 2016-08-11 08:04:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 08:06:14]

Description was changed from

==========
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285
==========

to

==========
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests.

BUG=636285

Committed: https://crrev.com/54a8f9a2dd2cdc8768220d60e6dd369ff05378c5
Cr-Commit-Position: refs/heads/master@{#411289}
==========

[commit-bot: I haz the power, 2016-08-11 08:06:15]

Patchset 2 (id:??) landed as
https://crrev.com/54a8f9a2dd2cdc8768220d60e6dd369ff05378c5
Cr-Commit-Position: refs/heads/master@{#411289}