Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2234773002: base: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, gavinp+memory_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. BUG=636301 Committed: https://crrev.com/52f72ddab9e68a2218a1400d53f6378749bff2c9 Cr-Commit-Position: refs/heads/master@{#411739}

Patch Set 1 #

Patch Set 2 : Remove extra base:: prefixes #

Patch Set 3 : Rebased #

Patch Set 4 : Removed unnecessary formatting change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/debug/activity_analyzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/ios/crb_protocol_observers.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/scoped_vector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_observer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Sami
PTAL. I've only added the namespace prefix to usages outside the base namespace.
4 years, 4 months ago (2016-08-12 11:36:37 UTC) #9
danakj
LGTM
4 years, 4 months ago (2016-08-12 18:07:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234773002/60001
4 years, 4 months ago (2016-08-12 18:09:17 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-12 19:45:08 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:48:37 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/52f72ddab9e68a2218a1400d53f6378749bff2c9
Cr-Commit-Position: refs/heads/master@{#411739}

Powered by Google App Engine
This is Rietveld 408576698