Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2234753002: media: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, jshin+watch_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 TBR=chcunningham@chromium.org Committed: https://crrev.com/03a07cb6e22221efeadb1212418eaee92976a3da Cr-Commit-Position: refs/heads/master@{#411662}

Patch Set 1 #

Patch Set 2 : Android/CrOS changes #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M media/base/android/access_unit_queue.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/text_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/cdm_session_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/net/cast_transport_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/sender/audio_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/player_tracker_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/frame_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/h264_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/media_source_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_content_encodings_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 13:32:21 UTC) #5
chcunningham
On 2016/08/10 13:32:21, Sami wrote: > PTAL. How are we currently supporting both base:: and ...
4 years, 4 months ago (2016-08-10 18:41:31 UTC) #10
Sami
On 2016/08/10 18:41:31, chcunningham wrote: > On 2016/08/10 13:32:21, Sami wrote: > > PTAL. > ...
4 years, 4 months ago (2016-08-11 09:13:44 UTC) #13
chcunningham1
lgtm
4 years, 4 months ago (2016-08-11 17:10:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234753002/40001
4 years, 4 months ago (2016-08-12 12:28:20 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/236913)
4 years, 4 months ago (2016-08-12 12:31:58 UTC) #23
Sami
Looks like the presubmit freaked out since your lg2m came from @google.com instead of @chromium.org. ...
4 years, 4 months ago (2016-08-12 14:36:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234753002/40001
4 years, 4 months ago (2016-08-12 14:37:02 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 15:51:02 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 15:52:45 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03a07cb6e22221efeadb1212418eaee92976a3da
Cr-Commit-Position: refs/heads/master@{#411662}

Powered by Google App Engine
This is Rietveld 408576698