|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by yoichio Modified:
4 years, 3 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd UseCounter for draggable attribute
1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes
is dragged when user drags pointer:
2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not:
https://w3c.github.io/html/editing.html#drag-and-drop
3. Thus we should deprecate |-webkit-user-drag| for interoperability.
However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate
immediately:
https://www.chromestatus.com/metrics/css/timeline/popularity/337
But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate
that stream by deprecating |-webkit-user-drag|.
Committed: https://crrev.com/fa07c88ba5aced63585ab7b32d20a7aa3f18f66f
Cr-Commit-Position: refs/heads/master@{#415116}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Patch Set 5 : rebase #Patch Set 6 : rebase #Patch Set 7 : rebase #
Messages
Total messages: 53 (30 generated)
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== draggable usecounter BUG= ========== to ========== Add UseCounter for draggable attribute I intend to deprecate -webkit-user-drag. BUG= ==========
yoichio@chromium.org changed reviewers: + tkent@chromium.org
> Add UseCounter for draggable attribute > > I intend to deprecate -webkit-user-drag. I don't catch you. Why do you count |draggable| content attribute to deprecate |-webkit-user-drag| CSS property?
On 2016/08/17 01:19:00, tkent wrote: > > Add UseCounter for draggable attribute > > > > I intend to deprecate -webkit-user-drag. > > I don't catch you. Why do you count |draggable| content attribute to deprecate > |-webkit-user-drag| CSS property? That's because 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|.
On 2016/08/17 at 02:09:33, yoichio wrote: > But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that > stream by deprecating |-webkit-user-drag|. ok, I understand. lgtm
Description was changed from ========== Add UseCounter for draggable attribute I intend to deprecate -webkit-user-drag. BUG= ========== to ========== Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. ==========
yoichio@chromium.org changed reviewers: + mpearson@chromium.org
mpearson@, could you review histograms.xml?
histograms.xml lgtm
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2234733002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2234733002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2234733002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2234733002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2234733002/#ps120001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. ========== to ========== Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. ========== to ========== Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. Committed: https://crrev.com/fa07c88ba5aced63585ab7b32d20a7aa3f18f66f Cr-Commit-Position: refs/heads/master@{#415116} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/fa07c88ba5aced63585ab7b32d20a7aa3f18f66f Cr-Commit-Position: refs/heads/master@{#415116} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
