Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2234733002: Add UseCounter for draggable attribute (Closed)

Created:
4 years, 4 months ago by yoichio
Modified:
4 years, 3 months ago
Reviewers:
tkent, Mark P
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for draggable attribute 1. Both |draggable| and |-webkit-user-drag| mean the element with the attributes is dragged when user drags pointer: 2. |draggeble| is the HTML5 standard but |-webkit-user-drag| is not: https://w3c.github.io/html/editing.html#drag-and-drop 3. Thus we should deprecate |-webkit-user-drag| for interoperability. However, |-webkit-user-drag| is used 4% in wild. That's high to deprecate immediately: https://www.chromestatus.com/metrics/css/timeline/popularity/337 But if |draggable| is used higher than |-webkit-user-drag|, we can accelarate that stream by deprecating |-webkit-user-drag|. Committed: https://crrev.com/fa07c88ba5aced63585ab7b32d20a7aa3f18f66f Cr-Commit-Position: refs/heads/master@{#415116}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 53 (30 generated)
yoichio
4 years, 4 months ago (2016-08-15 06:25:24 UTC) #7
tkent
> Add UseCounter for draggable attribute > > I intend to deprecate -webkit-user-drag. I don't ...
4 years, 4 months ago (2016-08-17 01:19:00 UTC) #8
yoichio
On 2016/08/17 01:19:00, tkent wrote: > > Add UseCounter for draggable attribute > > > ...
4 years, 4 months ago (2016-08-17 02:09:33 UTC) #9
tkent
On 2016/08/17 at 02:09:33, yoichio wrote: > But if |draggable| is used higher than |-webkit-user-drag|, ...
4 years, 4 months ago (2016-08-17 02:15:09 UTC) #10
yoichio
mpearson@, could you review histograms.xml?
4 years, 4 months ago (2016-08-17 04:28:31 UTC) #13
Mark P
histograms.xml lgtm
4 years, 4 months ago (2016-08-17 16:58:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/1
4 years, 4 months ago (2016-08-18 02:06:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/253269) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-18 02:09:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/1
4 years, 4 months ago (2016-08-23 04:28:49 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/56517) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-23 04:31:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/20001
4 years, 4 months ago (2016-08-23 06:21:57 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/255828)
4 years, 4 months ago (2016-08-23 06:24:48 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/40001
4 years, 4 months ago (2016-08-24 04:53:35 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/267421)
4 years, 4 months ago (2016-08-24 06:40:09 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/60001
4 years, 4 months ago (2016-08-25 05:19:26 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/58173) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-25 05:21:43 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/80001
4 years, 4 months ago (2016-08-25 07:42:56 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280856)
4 years, 4 months ago (2016-08-25 09:39:10 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/120001
4 years, 3 months ago (2016-08-29 05:39:39 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131727)
4 years, 3 months ago (2016-08-29 07:21:23 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234733002/120001
4 years, 3 months ago (2016-08-30 02:43:08 UTC) #49
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-08-30 04:49:12 UTC) #51
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:51:13 UTC) #53
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/fa07c88ba5aced63585ab7b32d20a7aa3f18f66f
Cr-Commit-Position: refs/heads/master@{#415116}

Powered by Google App Engine
This is Rietveld 408576698